Add computer name to azure sd #9112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: darshanime <deathbullet@gmail.com>
darshanime
force-pushed
the
add_computer_name
branch
from
aa29460
to
c8a2ffd
Compare
discovery/azure/azure.go
Outdated
| @@ -490,6 +494,7 @@ func mapFromVMScaleSetVM(vm compute.VirtualMachineScaleSetVM, scaleSetName strin | |||
| return virtualMachine{ | |||
| ID: *(vm.ID), | |||
| Name: *(vm.Name), | |||
| ComputerName: *(vm.VirtualMachineScaleSetVMProperties.OsProfile.ComputerName), | |||
There was a problem hiding this comment.
Thanks for this. I tend to be very cautious here and add a few nil checks. Are those fields all guaranteed to be here?
There was a problem hiding this comment.
thanks! addressed.
There was a problem hiding this comment.
we were not cautious enough :) #9382
There was a problem hiding this comment.
😢 sorry about this. I saw you mentioned I will work on a fix ASAP. already, let me know if I can help.
Signed-off-by: darshanime <deathbullet@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8499
Signed-off-by: darshanime deathbullet@gmail.com