Add scrape_timeout_seconds metric (behind feature flag) #9247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, do we want to have the feature flag more generic, e.g. extra-scrape-metrics? So we let the door open for #7722 and potentially others. |
|
I see no issue with |
SuperQ
force-pushed
the
superq/scrape_timeout_feature
branch
from
792e995
to
aaa675f
Compare
|
let's have #8911 first, because it will be easier to rebase your pull request than that one. |
SuperQ
force-pushed
the
superq/scrape_timeout_feature
branch
3 times, most recently
from
1d8f237
to
988c522
Compare
roidelapluie
changed the title
roidelapluie
reviewed
Sep 1, 2021
roidelapluie
reviewed
Sep 1, 2021
SuperQ
force-pushed
the
superq/scrape_timeout_feature
branch
from
988c522
to
267c9bd
Compare
roidelapluie
approved these changes
Sep 1, 2021
prymitive
reviewed
Sep 1, 2021
|
Since we will have other metrics pretty soon, WDYT about changing directly the internal variable names? |
|
sorry, I did not mean to close it |
Add a new built-in metric `scrape_timeout_seconds` to allow monitoring of the ratio of scrape duration to the scrape timeout. Hide behind a feature flag to avoid additional cardinality by default. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/scrape_timeout_feature
branch
from
267c9bd
to
31f4108
Compare
|
Thanks! |
valyala
added a commit
to VictoriaMetrics/VictoriaMetrics
that referenced
this pull request
Sep 12, 2021
…ape target in the same way as Prometheus 2.30 does See prometheus/prometheus#9247
valyala
added a commit
to VictoriaMetrics/VictoriaMetrics
that referenced
this pull request
Sep 12, 2021
…ape target in the same way as Prometheus 2.30 does See prometheus/prometheus#9247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new built-in metric
scrape_timeout_secondsto allow monitoringof the ratio of scrape duration to the scrape timeout. Hide behind a
feature flag to avoid additional cardinality by default.
Signed-off-by: SuperQ superq@gmail.com