Kubernetes service discovery: add provider ID label #9603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
approved these changes
Nov 22, 2021
|
looks like we need to resolve a conflict, otherwise this looks great! |
When using Kubernetes on cloud providers, nodes will have the spec.providerID field populated to contain the cloud provider specific name of the EC2/GCE/... instance. Let's expose this information as an additional label, so that it's easier to annotate metrics and alerts to contain the cloud provider specific name of the instance to which it pertains. Signed-off-by: Ed Schouten <eschouten@apple.com>
EdSchouten
force-pushed
the
eschouten/20211019-spec-provider-id
branch
from
25e0a21
to
4edb998
Compare
|
No worries! Just rebased this change! |
valyala
added a commit
to VictoriaMetrics/VictoriaMetrics
that referenced
this pull request
Jan 13, 2022
…ider_id` label for discovered Kubernetes nodes in the same way as Prometheus does See prometheus/prometheus#9603
valyala
added a commit
to VictoriaMetrics/VictoriaMetrics
that referenced
this pull request
Jan 13, 2022
…ider_id` label for discovered Kubernetes nodes in the same way as Prometheus does See prometheus/prometheus#9603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Kubernetes on cloud providers, nodes will have the
spec.providerID field populated to contain the cloud provider specific
name of the EC2/GCE/... instance.
Let's expose this information as an additional label, so that it's
easier to annotate metrics and alerts to contain the cloud provider
specific name of the instance to which it pertains.
Signed-off-by: Ed Schouten eschouten@apple.com