Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker container versioning not implemented #66

Closed
crisidev opened this issue Nov 30, 2015 · 7 comments
Closed

Docker container versioning not implemented #66

crisidev opened this issue Nov 30, 2015 · 7 comments

Comments

@crisidev
Copy link

Hi,
I am using pushgateway and I would like to use the official prom/pushgateway container from docker hub.
The versioning system is not implemented and currently prom/pushgateway:latest contains pushgateway 0.2.0. Is it possible to push containers with a sane versioning system?

@beorn7
Copy link
Member

beorn7 commented Dec 1, 2015

@discordianfish We need Docket help! What is @crisidev talking about? :)

@crisidev
Copy link
Author

crisidev commented Dec 1, 2015

I am speaking about the fact that prom/pushgateway docker containers on docker hub are pushed as just latest tag and not also with the correct version as tag. Example: current version of prom/pushgateway:latest is 0.2.0. Can you also push 0.2.0 as tag?

@fabxc
Copy link
Contributor

fabxc commented Dec 3, 2015

Did the same as for node_exporter.

@crisidev
Copy link
Author

crisidev commented Dec 3, 2015

Thanks!

@discordianfish
Copy link
Member

@grobie: What are your plans with the binary builds? I was waiting for that with looking into how to fix this tagging issue properly.. Docker hub doesn't track remote tags which sucks.. We should either create our own images and push them to the hub - or switch things to quary.io which supports tacking of all tags.

@jimmidyson
Copy link

@discordianfish Docker hub can track git tags now, but only on new tag push. Mapping git tag name -> docker tag name.

@sdurrheimer
Copy link
Contributor

This is fixed by #76. Future iteration of releases will have a sane docker image versioning.

  • master tag for the latest commit in the master
  • x.x.x-x tag for new pre-release
  • x.x.x and latest tag for new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants