Migrate from go-bindata to vfsgen #198
Merged
+1,482
−805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
Great, thanks. BTW: I still see a diff in file timestamps if I run But anyway, nothing gets worse in that regard. |
beorn7
approved these changes
Aug 28, 2018
Hmm, I don't see the same thing. |
|
Most likely because your files still have the same timestamp an when you ran |
|
Ah you're right, I've been fooled by my local filesystem! shurcooL/vfsgen#26 is the upstream issue. I might experiment with something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193
The PR is based on prometheus/prometheus#4430.