Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run docker container as root #202

Merged
merged 1 commit into from Apr 17, 2019
Merged

Don't run docker container as root #202

merged 1 commit into from Apr 17, 2019

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Apr 17, 2019

Run statsd_exporter as nobody.

Closes: #201

Signed-off-by: Ben Kochie superq@gmail.com

Run statsd_exporter as `nobody`.

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ requested a review from matthiasr April 17, 2019 15:05
@matthiasr
Copy link
Contributor

Thank you!

@matthiasr matthiasr merged commit 0766e70 into master Apr 17, 2019
matthiasr pushed a commit that referenced this pull request Apr 17, 2019
Signed-off-by: Matthias Rampke <mr@soundcloud.com>
@matthiasr matthiasr deleted the superq/docker_user branch April 17, 2019 15:26
matthiasr pushed a commit to prometheus/graphite_exporter that referenced this pull request Apr 17, 2019
Similar in spirit to prometheus/statsd_exporter#202 and others.

Signed-off-by: Matthias Rampke <mr@soundcloud.com>
matthiasr pushed a commit to prometheus/influxdb_exporter that referenced this pull request Apr 17, 2019
Similar in spirit to prometheus/statsd_exporter#202 and others.

Signed-off-by: Matthias Rampke <mr@soundcloud.com>
matthiasr pushed a commit that referenced this pull request May 15, 2019
* [CHANGE] Do not run as root in the Docker container by default ([#202](#202))
* [FEATURE] Add metric for count of events by action ([#193](#193))
* [FEATURE] Add metric for count of distinct metric names ([#200](#200))
* [FEATURE] Add UNIX socket listener support ([#199](#199))
* [FEATURE] Accept Datadog [distributions](https://docs.datadoghq.com/graphing/metrics/distributions/) ([#211](#211))
* [ENHANCEMENT] Add a health check to the Docker container ([#182](#182))
* [ENHANCEMENT] Allow inconsistent label sets ([#194](#194))
* [ENHANCEMENT] Speed up sanitization of metric names ([#197](#197))
* [ENHANCEMENT] Enable pprof endpoints ([#205](#205))
* [ENHANCEMENT] DogStatsD tag parsing is faster ([#210](#210))
* [ENHANCEMENT] Cache mapped metrics ([#198](#198))
* [BUGFIX] Fix panic if a mapping resulted in an empty name ([#192](#192))
* [BUGFIX] Ensure that there are always default quantiles if using summaries ([#212](#212))
* [BUGFIX] Prevent ingesting conflicting metric types that would make scraping fail ([#213](#213))

With #192, the count of events rejected because of negative counter increments has moved into the `statsd_exporter_events_error_total` metric, instead of being lumped in with the different kinds of successful events.

Signed-off-by: Matthias Rampke <mr@soundcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run docker container as root
2 participants