Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Ingested Lines #305

Merged
merged 3 commits into from May 29, 2020
Merged

Conversation

chai-nadig
Copy link
Contributor

@chai-nadig chai-nadig commented May 13, 2020

@chai-nadig chai-nadig force-pushed the chai/log-ingested-metrics branch 4 times, most recently from 087808f to 8174042 Compare May 13, 2020 07:41
Copy link
Contributor

@matthiasr matthiasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Only a few comments

pkg/event/event.go Outdated Show resolved Hide resolved
pkg/listener/listener.go Outdated Show resolved Hide resolved
pkg/listener/listener.go Outdated Show resolved Hide resolved
pkg/listener/listener.go Outdated Show resolved Hide resolved
Chai Nadig and others added 3 commits May 13, 2020 23:58
Signed-off-by: Chai Nadig <chaitanya.nadig@gmail.com>
Signed-off-by: Chai Nadig <chaitanya.nadig@gmail.com>
Signed-off-by: Chai Nadig <chaitanya.nadig@gmail.com>
@chai-nadig chai-nadig requested a review from matthiasr May 14, 2020 07:00
@matthiasr matthiasr merged commit 3908609 into prometheus:master May 29, 2020
@matthiasr
Copy link
Contributor

Beautiful, thank you very much!

matthiasr added a commit that referenced this pull request May 29, 2020
add changelog entry for #305, cut a release

Signed-off-by: Matthias Rampke <matthias@prometheus.io>
@chai-nadig chai-nadig deleted the chai/log-ingested-metrics branch May 29, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log ingested metrics at debug level
2 participants