Use the instance registry instead of the prometheus.registry #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Durham <mattdurham@ppog.org>
mattdurham
force-pushed
the
use_instance_registry
branch
from
b383b6f
to
aadb43e
Compare
|
Thank you! I can see that this is a bug but I am struggling to formulate a changelog entry. @mattdurham could you suggest one that explains to users what problem this release would fix for them? |
|
Ah, do I understand correctly that in the exporter itself this worked incidentally (because the Registerer we use is the global registry), but it affected library users? |
matthiasr
added a commit
that referenced
this pull request
Nov 26, 2021
Signed-off-by: Matthias Rampke <matthias@prometheus.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the usage of the instance for these options. For the Grafana Agent this is preventing certain types of stats from being pushed. @matthiasr