Use common/version and common/log packages #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discordianfish
force-pushed
the
fish/use-version-package
branch
from
2db294e
to
735516a
Compare
| @@ -265,7 +265,7 @@ func (b *Exporter) Listen(e <-chan Events) { | |||
| eventStats.WithLabelValues("timer").Inc() | |||
|
|
|||
| default: | |||
| log.Println("Unsupported event type") | |||
| log.Infoln("Unsupported event type") | |||
There was a problem hiding this comment.
This should we Warnln or Errorln.
discordianfish
force-pushed
the
fish/use-version-package
branch
from
735516a
to
e203bc8
Compare
| err = mapper.initFromFile(fileName) | ||
| if err != nil { | ||
| log.Println("Error reloading config:", err) | ||
| log.Infoln("Error reloading config:", err) |
discordianfish
force-pushed
the
fish/use-version-package
branch
from
e203bc8
to
03fde8f
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38