Add scale field to mapping config
#499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. This needs a DCO sign-off. You can use |
This field allows configuring unit conversions in mappings. For example: mappings: - match: foo.latency_ms name: foo_latency_seconds scale: 0.001 - match: bar.processed_kb name: bar_processed_bytes scale: 1024 Signed-off-by: Eddie Bracho <eddiebracho@gmail.com>
|
Very nice! Only one more thing I would ask: could you please add a section to the README about this so others can find this feature? Bonus points if you include an example 😄 |
Signed-off-by: Eddie Bracho <eddiebracho@gmail.com>
|
Wonderful, thank you! |
matthiasr
added a commit
to prometheus/graphite_exporter
that referenced
this pull request
Jun 2, 2023
Strictly speaking we're just updating dependencies, but this imports the scaling parameter feature from prometheus/statsd_exporter#499. Signed-off-by: Matthias Rampke <matthias@prometheus.io>
|
Thanks for maintaining this project! It's been super helpful for us during a short-notice metrics pipeline migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
This field allows configuring unit conversions in mappings. This is important for following prometheus best practices, which states that metrics should use base units (e.g. seconds, not milliseconds). For example: