Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax check for changes in grafana dashboards #364

Open
geekodour opened this issue May 9, 2020 · 0 comments
Open

Syntax check for changes in grafana dashboards #364

geekodour opened this issue May 9, 2020 · 0 comments

Comments

@geekodour
Copy link
Member

Grafana dashboard configmap automation was added in : #335

Since we're going to work with improving the current Grafana dashboard for prombench and test-infra in general, it'll be good to have a syntax check to avoid problems like this. also will be nice to have some kind of basic formatting tool to do the formatting aswell, something like go fmt but to format the json inside the dashboard configmaps. But syntax check is higher priority here than the formatter.

It'll also be nice to have some kind documentation on how to add new changes to prombench dashboard.

cc: @rajdas98 @drumilpatel2000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants