Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch-fix to Royale SDK v0.9.6 installation #17

Closed
rat-moonshine opened this issue Oct 16, 2019 · 5 comments
Closed

Patch-fix to Royale SDK v0.9.6 installation #17

rat-moonshine opened this issue Oct 16, 2019 · 5 comments

Comments

@rat-moonshine
Copy link
Collaborator

rat-moonshine commented Oct 16, 2019

During #16 testing Joel noticed that on Windows project compilation with newly downloaded version of Royale SDK v0.9.6 throws many errors.

Upon investigation, it turned out the SDK requires some patch-fixes to work, after being downloaded. Joel confirmed Piotr's suggested fix worked for him.

Joel suggested a fix-approach at Moonshine-SDK-Installer side based on Piotr's above suggestion, until Apache introduce any fix from their side. The idea is to modify the discussed framework/royale-config.xml after the SDK being downloaded.

@rat-moonshine rat-moonshine self-assigned this Oct 16, 2019
@rat-moonshine rat-moonshine added this to the v3.3.1 milestone Oct 16, 2019
@rat-moonshine rat-moonshine changed the title Patch-fix on Royale SDK v0.9.6 installation Patch-fix to Royale SDK v0.9.6 installation Oct 16, 2019
@rat-moonshine
Copy link
Collaborator Author

rat-moonshine commented Oct 16, 2019

Based on my discussion with @JoelProminic I created an Ant build-script to remove everything inside the <library-path> tag in royale-config.xml as suggested. The script tested working fine and I able to use the downloaded Royale SDK without any problem.

The Ant build script has usage of replaceregexp.

Apache SDK installer has an usage of ActionSctipt based Ant API. I think this reduce dependency of having Ant in user's system.

However, using the same API throws error while using the build-script that we made for this patch-fix:

Error: no processor for replaceregexp
at org.apache.flex.xml::XMLTagProcessor/processXMLTag()[/Moonshine-SDK-Installer/flex-utilities/flex-installer/ant_on_air/src/org/apache/flex/xml/XMLTagProcessor.as:50] 

After some investigation it turned out that no corresponding reference-class-file for replaceregexp exists to the ActionScript implementation of Ant API. I confirm the case by adding different Ant tags to the build-script file - those are not exists to the linked location.

I'm not sure I clearly understand how these tag files work in this between time. On other hand we can run Ant build script file with NativeProcess but that will create dependency of having Ant in user's system.

We can discuss on this further in today's meeting.

@rat-moonshine
Copy link
Collaborator Author

As discussed, we'll bundle a fixed-config XML file within Moonshine SDK Installer which will be use to overwrite Royale's once the SDK is downloaded.

@rat-moonshine
Copy link
Collaborator Author

Patch-fix added to replace original royale-config.xml with fixed config version. Building at Bamboo, shortly.

@JoelProminic
Copy link
Contributor

I used Moonshine SDK Installer to download a new Royale build, and tested again with each project:

OS Type Result
macOS Royale Basic Works
macOS Royale Jewel Works
Windows Royale Basic Works

@piotrzarzycki21
Copy link
Collaborator

@rat-moonshine If it's working please close it and let's describe this in CHANGELOG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants