Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links for download Apache Royale 0.9.6 #16

Closed
piotrzarzycki21 opened this issue Oct 10, 2019 · 17 comments
Closed

Add links for download Apache Royale 0.9.6 #16

piotrzarzycki21 opened this issue Oct 10, 2019 · 17 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@piotrzarzycki21
Copy link
Collaborator

We need to add newest Apache Royale release to our installer. All links for download can be found here

@piotrzarzycki21 piotrzarzycki21 added the enhancement New feature or request label Oct 10, 2019
@piotrzarzycki21 piotrzarzycki21 added this to the v3.3.1 milestone Oct 10, 2019
@rat-moonshine
Copy link
Collaborator

Does Moonshine SDK Installer also deployed to you somewhere in Moonshine website as Moonshine-IDE compilation does (at Bamboo), @piotrzarzycki21 ?

@piotrzarzycki21
Copy link
Collaborator Author

Does Moonshine SDK Installer also deployed to you somewhere in Moonshine website as Moonshine-IDE compilation does (at Bamboo), @piotrzarzycki21 ?

Nope

@rat-moonshine
Copy link
Collaborator

Yeah, I see that.. We probably need to have the deployment added to the plan also. For now, here's the link for your tests:
https://spaces.hightail.com/space/dhMpju9MTw

@piotrzarzycki21
Copy link
Collaborator Author

Please add that changes to CHANGELOG

@piotrzarzycki21
Copy link
Collaborator Author

I know that is an enhancement, but I think we should display somewhere version of SDK which we are providing for download.

@piotrzarzycki21
Copy link
Collaborator Author

It doesn't have to as part of this update of course.

rat-moonshine added a commit that referenced this issue Oct 10, 2019
@rat-moonshine
Copy link
Collaborator

I have updated the CHANGELOG.

I think somewhere in old mockups there were a version figure in layouts. You can open a separate ticket for this, we shall look into that.

@JoelProminic
Copy link
Contributor

I am getting a lot of errors like this with the Royale Browser Templates in Moonshine after the update:

: /Users/-user-/Downloads/MoonshineSDKs/Royale_SDK/apache-royale-0.9.6-bin-js/royale-asjs/frameworks/royale-config.xml(129): col: 0 Error: unable to open '/Users/-user-/Downloads/MoonshineSDKs/Royale_SDK/apache-royale-0.9.6-bin-js/royale-asjs/frameworks/libs/Basic.swc'.
: /Users/-user-/Downloads/MoonshineSDKs/Royale_SDK/apache-royale-0.9.6-bin-js/royale-asjs/frameworks/royale-config.xml (line: 129)
:       </library-path>

It looks like this issue is already being discussed: http://apache-royale-development.20373.n8.nabble.com/Broken-royale-config-in-JS-only-build-of-released-Apache-Royale-SDK-0-9-6-td12515.html

@piotrzarzycki21's fix worked for me: http://apache-royale-development.20373.n8.nabble.com/Broken-royale-config-in-JS-only-build-of-released-Apache-Royale-SDK-0-9-6-td12515.html#a12543

Do we want to apply this fix automatically with Moonshine SDK Installer, or is there a fix planned for the Royale SDK?

@piotrzarzycki21
Copy link
Collaborator Author

Well I'm not sure whether from the license perspective we can do such things and provide SDK. I saw commit from Alex - it should be fixed now I nightly. I need to think whether I'm ready for release struggle again ;)

@JoelProminic
Copy link
Contributor

I don't mean downloading the AIR SDK - I think we have discussed this in the past, but I don't immediately remember what we decided for this. Rather, I mean commenting out the entries in royale-config.xml. Is this a problem when we are providing the JS-only version?

@piotrzarzycki21
Copy link
Collaborator Author

This is what I mean. I don't know whether we can do that and provide changed SDK. :) I will ask on dev on Sunday.

@JoelProminic
Copy link
Contributor

What I had in mind was using the official ZIP file, but running a script afterwards to remove the lines that broke the builds (assuming they are not needed for anything else). If this is a problem with the license, then we may want to review the current behavior - I think that are adding executable file permissions to royale-asjs/bin and royale-asjs/js/bin

@piotrzarzycki21
Copy link
Collaborator Author

What I had in mind was using the official ZIP file, but running a script afterwards to remove the lines that broke the builds (assuming they are not needed for anything else). If this is a problem with the license, then we may want to review the current behavior - I think that are adding executable file permissions to royale-asjs/bin and royale-asjs/js/bin

Ohh... That's also great idea. @rat-moonshine what do you think about that ?

@JoelProminic
Copy link
Contributor

@piotrzarzycki21, after talking with @rat-moonshine, there were some points I wanted to clarify:

  • Is this a general bug with the Royale SDK that will affect all users?
  • If this is not a general SDK bug, what is special about our templates? Should we fix the templates instead?
  • Are you working on deploying another release for the SDK to fix this? If so, when is this expected to be ready? If it is soon, then it may be overkill to implement a fix in Moonshine SDK Installer

@piotrzarzycki21
Copy link
Collaborator Author

@piotrzarzycki21, after talking with @rat-moonshine, there were some points I wanted to clarify:

  • Is this a general bug with the Royale SDK that will affect all users?
  • If this is not a general SDK bug, what is special about our templates? Should we fix the templates instead?
  • Are you working on deploying another release for the SDK to fix this? If so, when is this expected to be ready? If it is soon, then it may be overkill to implement a fix in Moonshine SDK Installer
  1. Yes it affects all Royale users who use JS-only build
  2. I saw commits from Alex related to that problem, so it may be fixed already. Even if I start working on releasing another version I think it takes at least 1 week to finish whole process. I didn't start yet.

@piotrzarzycki21
Copy link
Collaborator Author

Guys Alex suggested similar solution to your @JoelProminic . Let's go with that direction and we will be good with licensing. @rat-moonshine can you look into that ? I think implementation should be on Installer sight.

@rat-moonshine
Copy link
Collaborator

rat-moonshine commented Oct 16, 2019

Since the purpose of this issue have met, I'm creating a separate issue #17 to follow-up the patch-fix to Royale SDK. Please, let's discuss relevant things to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants