feat: rename promoted-event-logger-ts to promoted-snowplow-logger
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinyius
reviewed
Mar 1, 2021
There was a problem hiding this comment.
so this is a repo rename ? why does it touch all of of the files like repo setup stuff that seems pretty unreleated to the target name change.
kinda hard to know what/how things are changing beyond the title of the pr. probably just my unfamiliarity with gh's pr review ux, so lmk if there's an easier way for me to grok this change.
|
I created a new repo and copied the files over. With npm auto-deploy, I don't know if renames will work correctly. I figured it was easier to create a whole new repo and npm package. |
|
sgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.