fix: fix the bug "the prompt.id in conversationKey are undefined" #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it's like: --------conversationKey start--------- provider.id:undefined --------conversationKey end--------- In fact, it should be --------conversationKey start--------- provider.id:prompt.id --------conversationKey end---------
qwlong
changed the title
|
Thanks @qwlong! Looks like there are some test failures we need to look at |
|
@typpo |
mldangelo
force-pushed
the
main
branch
2 times, most recently
from
99b5c63
to
790ec30
Compare
typpo
force-pushed
the
main
branch
11 times, most recently
from
b2323de
to
3ad344f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's like:
--------conversationKey start---------
provider.id:undefined
--------conversationKey end---------
In fact, it should be
--------conversationKey start---------
provider.id:prompt.id
--------conversationKey end---------