-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Cloudflare AI Provider #817
Conversation
@typpo Anything else major besides docs that you think might be missing, assuming a correct implementation on my part of the CF API calls? |
Note to self, look at https://github.com/promptfoo/promptfoo/pull/711/files for inspiration on examples + docs |
@typpo the line changes related to formatting are due to VS code auto-format. I tried to remove then by running |
Nice change! This looks pretty much ready to go. Hopefully @CamdenClark can find the time to verify this weekend, otherwise I'll figure out how to get myself set up on Cloudflare AI :) |
I got to it! It works on my machine! Thanks for taking this up, I got super distracted and forgot to do it 😓 In the future it would be cool to get LoRA support but that's not necessary to merge in my opinion. Feel free to tag me on a non-draft PR if you want another review. |
one other thing you might want to know -- I had to build promptfoo on a new machine with node 22 and I got some weird C++ errors with better-sqlite. Might want to put a note recommending node 20. (Unrelated to this PR specifically) |
@CamdenClark thanks for testing for me.... @typpo im working now on the docco after fixing the failing tests today. Would you mind please re-triggering the CI test workflow so that I can verify that worked? Assuming thats green, and once I push one more commit for the docs and a few more examples, then this should be good to go (though I'll do a final rebase against master before un-drafting it) |
…he cloudflare provider tests
…I failure and custom configuration pass-through of model parameters
a85ca35
to
d2e4991
Compare
@typpo this is now done and awaiting final review + green CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks excellent! Nice work! Just waiting for green CI and will land it ✨
🎉 Amazing work @jacobdr and thanks @CamdenClark for helping too! |
Closes #647
Cloudflare Workers AI provider implementation
===
This is a work in progress I wanted to put up for initial feedback. I still need to test it a bunch more locally and update the docs as well.