Skip to content

Fix lint issues.

Fix lint issues. #60

Triggered via push January 23, 2024 10:19
Status Failure
Total duration 2m 15s
Artifacts

ci.yaml

on: push
Matrix: phplint / phplint
Matrix: phpunit / phpunit
Fit to window
Zoom out
Zoom in

Annotations

39 errors and 10 warnings
phpunit / PHP 8.2 WordPress 6.1
Process completed with exit code 1.
phpunit / PHP 8.0 WordPress 6.1
The job was canceled because "_8_2_6_1" failed.
phpunit / PHP 8.0 WordPress 6.1
Process completed with exit code 1.
phpunit / PHP 8.1 WordPress 6.2
The job was canceled because "_8_2_6_1" failed.
phpunit / PHP 8.1 WordPress 6.2
Process completed with exit code 1.
phpunit / PHP 8.0 WordPress 6.3
The job was canceled because "_8_2_6_1" failed.
phpunit / PHP 8.0 WordPress 6.3
Process completed with exit code 1.
phpunit / PHP 8.2 WordPress 6.3
The job was canceled because "_8_2_6_1" failed.
phpunit / PHP 8.2 WordPress 6.3
Process completed with exit code 1.
phpunit / PHP 8.1 WordPress 6.3
The job was canceled because "_8_2_6_1" failed.
phpunit / PHP 8.1 WordPress 6.3
Process completed with exit code 1.
phpunit / PHP 8.2 WordPress 6.2
The job was canceled because "_8_2_6_1" failed.
phpunit / PHP 8.2 WordPress 6.2
Process completed with exit code 1.
phpunit / PHP 8.0 WordPress 6.2
The job was canceled because "_8_2_6_1" failed.
phpunit / PHP 8.0 WordPress 6.2
The operation was canceled.
coverage / coverage
Script "coverage" is not defined in this package
coverage / coverage
Process completed with exit code 1.
phpunit / PHP 8.1 WordPress 6.1
The job was canceled because "_8_2_6_1" failed.
phpunit / PHP 8.1 WordPress 6.1
The operation was canceled.
phpstan / phpstan: src/BrowserInformation.php#L348
Return type of Pronamic\WordPress\Pay\Gateways\Adyen\BrowserInformation::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
phpstan / phpstan: src/Gateway.php#L84
Parameter #1 $string of function md5 expects string, string|false given.
phpstan / phpstan: src/Gateway.php#L119
Method Pronamic\WordPress\Pay\Gateways\Adyen\Gateway::get_payment_methods() has parameter $args with no value type specified in iterable type array.
phpstan / phpstan: src/Gateway.php#L135
Parameter #1 $string of function md5 expects string, string|false given.
phpstan / phpstan: src/Gateway.php#L150
Parameter #1 $id of method Pronamic\WordPress\Pay\Core\Gateway::get_payment_method() expects string, string|null given.
phpstan / phpstan: src/Gateway.php#L221
Parameter #1 $type of class Pronamic\WordPress\Pay\Gateways\Adyen\PaymentMethodDetails constructor expects string, string|null given.
phpstan / phpstan: src/Integration.php#L549
Parameter #1 $url of function esc_url expects string, string|null given.
phpstan / phpstan: src/PaymentMethodDetails.php#L40
Return type of Pronamic\WordPress\Pay\Gateways\Adyen\PaymentMethodDetails::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
phpstan / phpstan: src/ReturnController.php#L271
Method Pronamic\WordPress\Pay\Gateways\Adyen\ReturnController::rest_api_adyen_redirect_permission() should return bool but returns int|false.
phpstan / phpstan: src/ReturnController.php#L353
Method Pronamic\WordPress\Pay\Gateways\Adyen\ReturnController::rest_api_adyen_error_permission() should return bool but returns int|false.
phpcs / phpcs: pronamic-pay-adyen.php#L40
Expected 1 space after FUNCTION keyword; 0 found
phpcs / phpcs: src/Client.php#L76
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$response'.
phpcs / phpcs: src/Client.php#L77
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$response'.
phpcs / phpcs: src/AbstractPaymentRequest.php#L309
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$country_code'.
phpcs / phpcs: src/Name.php#L101
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$infix'.
phpcs / phpcs: src/Gateway.php#L81
Expected 1 space after FUNCTION keyword; 0 found
phpcs / phpcs: src/Gateway.php#L247
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$result_code'.
phpcs / phpcs: src/LineItems.php#L90
Expected 1 space after FUNCTION keyword; 0 found
phpcs / phpcs: src/ReturnController.php#L53
Expected 1 space after FUNCTION keyword; 0 found
phpcs / phpcs: src/Address.php#L85
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$country'.
phpcs / phpcs: src/PaymentResponseAction.php#L56
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object
phpcs / phpcs: src/ObjectAccess.php#L29
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object
phpcs / phpcs: src/Error.php#L76
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object
phpcs / phpcs: src/PaymentResponse.php#L46
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object
phpcs / phpcs: src/PaymentDetailsResponse.php#L30
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object
phpcs / phpcs: src/PaymentSessionResponse.php#L73
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object
phpcs / phpcs: src/ServiceException.php#L104
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object
phpcs / phpcs: src/PaymentMethodsResponse.php#L55
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object
phpcs / phpcs: src/BrowserInformation.php#L271
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object
phpcs / phpcs: src/ResponseObject.php#L39
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object