Add support for in3 payment method

[rvdsteege]

From customer:

De in3 betaalmethode is geselecteerd in Mollie, deze is ook voor een aantal formulieren in GravityForms te selecteren maar in Memberpress krijgen we helaas de payment gateway niet te zien.

Klopt het dat dit nog niet mogelijk is? Zo ja wanneer zou dit wel mogelijk zijn?
Zo nee, kunnen jullie een oplossing geven hoe dit wel te integreren is in Memberpress?

Simply adding the in3 payment method to MemberPress currently results in the following gateway error message:

ERROR: Unprocessable Entity - The payment method does not support recurring type

If we don't set support for the subscription capabilities in MemberPress (like create-subscriptions) for a payment method, should we then still continue to try to add a subscription to the payment?

wp-pronamic-pay-memberpress/src/Gateways/Gateway.php

Lines 96 to 119 in b5b6be1

	// Capabilities.
	$gateway = Plugin::get_gateway( (int) $this->get_config_id() );
	if ( null !== $gateway ) {
	$capabilities = [ 'process-payments' ];
	$payment_method = $gateway->get_payment_method( (string) $this->payment_method );
	if ( null !== $payment_method && $payment_method->supports( 'recurring' ) ) {
	$capabilities = \array_merge(
	$capabilities,
	[
	'create-subscriptions',
	'cancel-subscriptions',
	'update-subscriptions',
	'subscription-trial-payment',
	]
	);
	}
	if ( $gateway->supports( 'refunds' ) ) {
	$capabilities[] = 'process-refunds';
	}
	}

wp-pronamic-pay-memberpress/src/Pronamic.php

Lines 123 to 136 in b5b6be1

	/**
	* Subscription.
	*/
	$subscription = self::get_subscription( $memberpress_transaction );
	if ( $subscription ) {
	$period = $subscription->new_period();
	if ( null === $period ) {
	throw new \Exception( 'Could not create new period for subscription.' );
	}
	$payment->add_period( $period );
	}

Internal Help Scout ticket: https://secure.helpscout.net/conversation/2275733463/25784

CC: @remcotolsma

[remcotolsma]

I think this is MemberPress territory and we have the next MemberPress issue open for that (not yet reported to MemberPress itself as far as I know):

• MemberPress does nothing with the gateway create-subscriptions capability memberpress#2

If we don't set support for the subscription capabilities in MemberPress (like create-subscriptions) for a payment method, should we then still continue to try to add a subscription to the payment?

I think so, for recurring memberships we also want users/administrators to see the error message:

ERROR: Unprocessable Entity - The payment method does not support recurring type

[rvdsteege]

Ah, I think I missed the one-time membership option. in3 works fine in that case and the error message is indeed correct then for recurring memberships. I created PR #14 to add the in3 payment method.