Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemberPress does nothing with the gateway create-subscriptions capability #2

Open
remcotolsma opened this issue Nov 3, 2022 · 1 comment

Comments

@remcotolsma
Copy link
Member

The default MemberPress gateways all have the create-subscriptions capability:

https://github.com/pronamic/memberpress/search?q=create-subscriptions

That is why we also have this in the Pronamic Pay MemberPress Add-On:

https://github.com/pronamic/wp-pronamic-pay-memberpress/blob/a9ed77a71e2c64ab14e744461661aba8ee08a121/src/Gateways/Gateway.php#L99-L118

You would expect MemberPress to also do something for gateways that don't have the create-subscriptions capability, but unfortunately that is not the case.

@rvdsteege
Copy link
Member

Posted by @remcotolsma in pronamic/wp-pronamic-pay-memberpress#12 (comment):

I think this is MemberPress territory and we have the next MemberPress issue open for that (not yet reported to MemberPress itself as far as I know):

#2

What exactly do we want to report / expect if create-subscriptions is not supported by a payment gateway?

Draft support message Hi,

We noticed you're setting the create-subscriptions capability in all payment gateways, however this capability seems not be used anywhere. What is it used for?

Background: a user of our Pronamic Pay plugin asked us to add support for a specific payment method. The payment method does not support recurring payments, so we don't set the create-subscriptions capability. However, the method can still be used for recurring memberships now, which results in a gateway error.

Best regards,
Pronamic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: External
Development

No branches or pull requests

2 participants