Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mollie components #40

Merged
merged 35 commits into from
Dec 6, 2023
Merged

Mollie components #40

merged 35 commits into from
Dec 6, 2023

Conversation

remcotolsma
Copy link
Member

No description provided.

@remcotolsma remcotolsma self-assigned this Dec 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (2a1aca6) 14.59% compared to head (80ab156) 15.86%.

Files Patch % Lines
src/CardField.php 8.10% 34 Missing ⚠️
src/Gateway.php 18.75% 13 Missing ⚠️
src/ScriptsController.php 89.47% 4 Missing ⚠️
src/Integration.php 40.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #40      +/-   ##
============================================
+ Coverage     14.59%   15.86%   +1.26%     
- Complexity      467      482      +15     
============================================
  Files            19       21       +2     
  Lines          2110     2206      +96     
============================================
+ Hits            308      350      +42     
- Misses         1802     1856      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remcotolsma remcotolsma linked an issue Dec 5, 2023 that may be closed by this pull request
src/Gateway.php Outdated

$profile_id = $profile->get_id();

\set_transient( $cache_key, $profile_id, \DAY_IN_SECONDS );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Mollie profile won't change for a given API key. Are transients suitable in this case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved Mollie profile ID to configuration meta in 494e0be.

@remcotolsma remcotolsma merged commit 4c7fd4c into main Dec 6, 2023
18 of 20 checks passed
@remcotolsma remcotolsma deleted the mollie-components branch December 6, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Add support for Mollie Components
3 participants