Use trial end date from trial_end_pre_cancellation meta for subscriptions pending cancellation.
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a WooCommerce subscription is marked for cancellation (either by the user through the account or an admin manually changing the subscription status to 'Pending cancellation'), WooCommerce Subscriptions updates the trial end date meta to
0and moves the current trial end date value to thetrial_end_pre_cancellationmeta:https://github.com/pronamic/woocommerce-subscriptions/blob/50b02db3314ce937e9a670b4215fa4cced7652cf/vendor/woocommerce/subscriptions-core/includes/class-wc-subscription.php#L444-L468
This PR resolves the fatal error from issue #14 in the subscription updater by using the trial end date from
trial_end_pre_cancellationmeta if thetrial_endmeta is empty.