Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cache key based on actual Python version #30

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

pronovic
Copy link
Owner

Currently, the dependency cache key uses the matrix.python value, which is 3.8, 3.9, 3.10, etc. However, when Poetry sets up a the virtualenv, it's for a particular Python version (say 3.10.6). If the Python version changes (say, to 3.10.7), the cache is no longer valid, because the Python executable can no longer be found. The fix is to set the cache key based on the actual Python version that was used to create the virtualenv, and not the matrix Python version.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.117% when pulling 5f79750 on ken/cache-fixes into 66be4d5 on master.

@pronovic pronovic merged commit cd44155 into master Sep 16, 2022
@pronovic pronovic deleted the ken/cache-fixes branch September 16, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants