Set cache key based on actual Python version #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the dependency cache key uses the
matrix.python
value, which is3.8
,3.9
,3.10
, etc. However, when Poetry sets up a the virtualenv, it's for a particular Python version (say3.10.6
). If the Python version changes (say, to3.10.7
), the cache is no longer valid, because the Python executable can no longer be found. The fix is to set the cache key based on the actual Python version that was used to create the virtualenv, and not the matrix Python version.