Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append comments on 'Files changed' page rather than 'Discussion' page #16

Closed
zoras opened this issue Nov 8, 2013 · 7 comments
Closed
Assignees

Comments

@zoras
Copy link

zoras commented Nov 8, 2013

Right now pronto appends automated comments in github's [Discussion](https://github.com/mmozuras/pronto/pull/14] page).

However it is more common to place the comments inline within the Files Changed tab.

It would be nice to see this behaviour ⛵

@mmozuras
Copy link
Member

mmozuras commented Nov 9, 2013

Thanks for the suggestion!

That's something I've already considered, but it will require some thought 😄. Currently, comments are created using repo comment API. To create comments on pull requests, pull request comment API should be used.

But it's not as simple as using a different API. Pull request comments require a different algorithm to figure out which commit introduced the change instead of simple blame that is currently used. And Pronto needs to be aware which pull request should be commented on (environment variable or parameter).

It's definitely something I want 🚢 too 😄

@ghost ghost assigned mmozuras Nov 9, 2013
@kryachkov
Copy link

Any news on this issue?

@mmozuras
Copy link
Member

@kryachkov with the release of rugged-0.21.0, which includes better git-blame support, I'm finally starting to work on it. If I won't hit any unexpected walls, I hope to release it with pronto-0.3.0 in the coming weeks.

@kryachkov
Copy link

Wow! Waiting with anticipation...

mmozuras added a commit that referenced this issue Aug 19, 2014
mmozuras added a commit that referenced this issue Aug 19, 2014
@kryachkov
Copy link

👍 Thank you

@mmozuras
Copy link
Member

@kryachkov no problem, I wanted it too 😄

Hopefully it works ok, though I kinda expect to run into some cases I didn't fully consider. Will start using internally, so should notice them pretty quickly.

@zoras
Copy link
Author

zoras commented Sep 11, 2014

Finally!
Thanks and cheers @mmozuras 🍸 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants