New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append comments on 'Files changed' page rather than 'Discussion' page #16
Comments
Thanks for the suggestion! That's something I've already considered, but it will require some thought 😄. Currently, comments are created using repo comment API. To create comments on pull requests, pull request comment API should be used. But it's not as simple as using a different API. Pull request comments require a different algorithm to figure out which commit introduced the change instead of simple It's definitely something I want 🚢 too 😄 |
Any news on this issue? |
@kryachkov with the release of rugged-0.21.0, which includes better git-blame support, I'm finally starting to work on it. If I won't hit any unexpected walls, I hope to release it with pronto-0.3.0 in the coming weeks. |
Wow! Waiting with anticipation... |
👍 Thank you |
@kryachkov no problem, I wanted it too 😄 Hopefully it works ok, though I kinda expect to run into some cases I didn't fully consider. Will start using internally, so should notice them pretty quickly. |
Finally! |
Right now pronto appends automated comments in github's [Discussion](https://github.com/mmozuras/pronto/pull/14] page).
However it is more common to place the comments inline within the Files Changed tab.
It would be nice to see this behaviour ⛵
The text was updated successfully, but these errors were encountered: