Run pronto on GitHub Actions without any reporting #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsander
force-pushed
the
fix-github-action-2
branch
from
1280880
to
26e8f79
Compare
|
The test commit that included a rubocop offense failed the action as expected: https://github.com/prontolabs/pronto/runs/2041862031?check_suite_focus=true#step:4:228 |
In prontolabs#401 we discussed that there currently is no 100% safe way to run pronto on `pull_request_target` actions we can not send any reports to the GitHub pull request. This simple action will show up as a failed check. The offences then need to be viewed in the action output.
dsander
force-pushed
the
fix-github-action-2
branch
from
ed1f0d7
to
d65baff
Compare
|
I removed 2.4 from the test matrix because of this failure https://github.com/prontolabs/pronto/runs/2041832382?check_suite_focus=true#step:3:33 |
|
Makes sense about the GitHub CI check for now! For the Ruby 2.4 failure, can't we override the gem version for 2.4 like it's done here? We'll have to add support for Gemfile.local in Gemfile but I think that's fine. |
dsander
force-pushed
the
fix-github-action-2
branch
from
2473f3e
to
7401880
Compare
|
We can, I simply wasn't aware of that trick 😄 |
ashkulz
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #401 we discussed that there
currently is no 100% safe way to run pronto on
pull_request_targetactions we can not send any reports to the GitHub pull request.
This simple action will show up as a failed check. The offences then
need to be viewed in the action output.