Ensure SemaphoreGroupPCD can't be used with STATIC_SIGNATURE_PCD_NULLIFIER #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #133
This PR was initially just meant to tackle issue #133, but in doing that I uncovered some other bugs / incomplete parts of the codebase that were necessary to test if this was done correctly. Here's a total list of what this PR contains:
SemaphoreGroupPCD
with STATIC_SIGNATURE_PCD_NULLIFIER, that notifies them their anonymity would be brokenusePendingPCD
hook from continuing to ping the server after receiving a PendingPCD with an ERROR status