Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure SemaphoreGroupPCD can't be used with STATIC_SIGNATURE_PCD_NULLIFIER #152

Merged
merged 8 commits into from
Apr 14, 2023

Conversation

RiverRuby
Copy link
Contributor

@RiverRuby RiverRuby commented Apr 11, 2023

Resolves #133

This PR was initially just meant to tackle issue #133, but in doing that I uncovered some other bugs / incomplete parts of the codebase that were necessary to test if this was done correctly. Here's a total list of what this PR contains:

  • Throw an error if user tries to make a SemaphoreGroupPCD with STATIC_SIGNATURE_PCD_NULLIFIER, that notifies them their anonymity would be broken
  • Prevent the usePendingPCD hook from continuing to ping the server after receiving a PendingPCD with an ERROR status
  • Transport error messages from server to client & display them so that they know what the error was

Copy link
Contributor

@ichub ichub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after you address the comments.

thanks for fixing up the server-side proving error handling too!

packages/semaphore-group-pcd/src/SemaphoreGroupPCD.ts Outdated Show resolved Hide resolved
packages/semaphore-group-pcd/src/SemaphoreGroupPCD.ts Outdated Show resolved Hide resolved
packages/semaphore-group-pcd/src/SemaphoreGroupPCD.ts Outdated Show resolved Hide resolved
@RiverRuby RiverRuby merged commit a7b90ac into main Apr 14, 2023
@RiverRuby RiverRuby deleted the vivek/group-pcd-fix branch April 14, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent STATIC_SIGNATURE_PCD_NULLIFIER from being used in SemaphoreGroupPCD so anonymity isn't broken
2 participants