Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(passport): keep connected account selection between signins #2320

Closed
freeatnet opened this issue May 24, 2023 · 1 comment · Fixed by #2363
Closed

feat(passport): keep connected account selection between signins #2320

freeatnet opened this issue May 24, 2023 · 1 comment · Fixed by #2363
Assignees
Labels
enhancement Indicates new feature requests

Comments

@freeatnet
Copy link

freeatnet commented May 24, 2023

Feature Request

Description

The “connected accounts” dropdown selection is reset for every sign-in attempt, even if the user previously authorized the app to access some of the connected accounts. Persisting authorization settings for the app-user pair would benefit both developers and app users:

  • As a user who uses a rollup.id-enabled app from multiple devices, having previous app authorizations automatically applied would let me sign in faster.
  • As a developer who uses the connected accounts list to populate user profile, I could rely on the fact that any changes to the connected accounts list are the result of intentional user action (as opposed to wondering if the user forgot to select all the again on sign-in).

Proposed Solution (if applicable)

Preserve the last "connected accounts" selection for the app-user pair.

Additional Context (if applicable)

This would also simplify incremental authorization (e.g., as an app, I only need user profile and connected accounts info for read-only access, and would only request access to their smart contract wallet when they want to make a write action).

@betimshahini betimshahini added the enhancement Indicates new feature requests label May 25, 2023
@maurerbot
Copy link
Contributor

Related #2338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants