feat(passport): keep connected account selection between signins #2363
Conversation
poolsar42
force-pushed
the
feat/2320-passport-keep-connected-selection
branch
from
e3f0546
to
5759730
Compare
poolsar42
force-pushed
the
feat/2320-passport-keep-connected-selection
branch
from
c57c6da
to
3cc1739
Compare
|
|
||
| let minDate = filteredEmailsFromConnectedAddresses[0].createdTimestamp! | ||
|
|
||
| if (preselected) { |
There was a problem hiding this comment.
Not quite following what this is supposed to be doing; the edges call returns items ordered by created timestamp already. Can you not just pick the first/last, as needed?
There was a problem hiding this comment.
Per our conversation in chatted I assumed we wanted to double check it here. If it's not needed - removing it
done ☑️
| import { getEmailIcon } from '@proofzero/utils/getNormalisedConnectedAccounts' | ||
| import { ThemeContext } from '@proofzero/design-system/src/contexts/theme' | ||
| import { AuthenticationScreenDefaults } from '@proofzero/design-system/src/templates/authentication/Authentication' | ||
| import { Helmet } from 'react-helmet' | ||
| import { getRGBColor } from '@proofzero/design-system/src/helpers' | ||
| import { AddressURNSpace } from '@proofzero/urns/address' | ||
| import type { DropdownSelectListItem } from '@proofzero/design-system/src/atoms/dropdown/DropdownSelectList' |
There was a problem hiding this comment.
Importer complaining about this import.
There was a problem hiding this comment.
Don't see it on my end. What does it say?
| form.append('createSCWallet', JSON.stringify({ | ||
| check: true, | ||
| nickname: appProfile.name | ||
| })) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not seeing the retrieval and pre-selection of values from an existing authorization, if available (ticket #2320). Has that been implemented?
poolsar42
force-pushed
the
feat/2320-passport-keep-connected-selection
branch
from
9f80d5c
to
e9123d6
Compare
poolsar42
force-pushed
the
feat/2320-passport-keep-connected-selection
branch
from
e9123d6
to
9f9a4cb
Compare
| request, | ||
| params: { clientId }, | ||
| context, | ||
| }) |
There was a problem hiding this comment.
don't think we need non dynamic scopes
| context.traceSpan | ||
| ) | ||
|
|
||
| const { addressURN } = await addressClient.initSmartContractWallet.query({ |
There was a problem hiding this comment.
why not import the actionLoader from the current create wallet route and pass in params?
There was a problem hiding this comment.
or create a helper functino that both acrtion loaders can use
| export const getDataForScopes = async ( | ||
| requestedScope: string[], | ||
| accountURN: AccountURN, | ||
| jwt?: string, | ||
| env?: any, | ||
| traceSpan?: any | ||
| traceSpan?: any, | ||
| preauthorizedScopes?: GetAuthorizedAppScopesMethodResult['claimValues'] |
There was a problem hiding this comment.
not sure we need any of this new stuff. we can just mix in the persona data to select the values on the client
| } | ||
| return addressType.charAt(0).toUpperCase() + addressType.slice(1) | ||
| } | ||
|
|
||
| export const getEmailDropdownItems = ( | ||
| connectedAddresses?: Addresses | null | ||
| connectedAddresses?: Addresses | null, | ||
| preselected = false, |
There was a problem hiding this comment.
try to defer to the client to handle to select them
poolsar42
force-pushed
the
feat/2320-passport-keep-connected-selection
branch
from
ae20939
to
7a69957
Compare
Description
Displays connected emails as connected accounts (it's a fix)
And also redesigns authz screen to display previously connected emails and sc wallets
Related Issues
Testing
Storybook and authz route
Checklist