Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(apps): upgrade connectkit and wagmi #2319

Merged
merged 21 commits into from
May 30, 2023
Merged

chore(apps): upgrade connectkit and wagmi #2319

merged 21 commits into from
May 30, 2023

Conversation

poolsar42
Copy link
Collaborator

@poolsar42 poolsar42 commented May 23, 2023 •
edited
Loading

Description

Upgrades connectkit and wagmi following this guide

One thing to notice:

  • With new connectkit it is required now to provide WalletConnectProjectId like here and here

We need to set up secret dev vars. Here's the migration guide for connectkit where this is explained

Related Issues

Testing

Log-in with wallet works like previously

  • Log in to passport with blockchain wallet
  • Tested it under apps/$clientId/designer/beta in console

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@poolsar42 poolsar42 self-assigned this May 23, 2023
@poolsar42 poolsar42 force-pushed the chore/2303-upgrade-connect-kit-and-wagmi branch 2 times, most recently from 8c01382 to dbaef64 Compare May 24, 2023 21:08
@poolsar42 poolsar42 marked this pull request as ready for review May 24, 2023 21:14
@poolsar42 poolsar42 marked this pull request as draft May 25, 2023 14:53
@poolsar42 poolsar42 force-pushed the chore/2303-upgrade-connect-kit-and-wagmi branch from 9e544e1 to 593ac50 Compare May 25, 2023 16:08
@poolsar42 poolsar42 marked this pull request as ready for review May 25, 2023 16:11
@poolsar42 poolsar42 marked this pull request as draft May 26, 2023 15:19
@poolsar42 poolsar42 force-pushed the chore/2303-upgrade-connect-kit-and-wagmi branch 2 times, most recently from 1c9fd3d to c7af01e Compare May 26, 2023 19:18
@poolsar42 poolsar42 marked this pull request as ready for review May 26, 2023 19:36
maurerbot
maurerbot requested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@maurerbot maurerbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WALLET_CONNECT_PROJECT_ID needs to be added to the wrangler files

@poolsar42 poolsar42 force-pushed the chore/2303-upgrade-connect-kit-and-wagmi branch from f598fdf to 2e0efa7 Compare May 30, 2023 14:33
@poolsar42 poolsar42 force-pushed the chore/2303-upgrade-connect-kit-and-wagmi branch from 2e0efa7 to 428b7ca Compare May 30, 2023 14:41
@poolsar42 poolsar42 force-pushed the chore/2303-upgrade-connect-kit-and-wagmi branch from 1a03bae to 55a5874 Compare May 30, 2023 15:22
@poolsar42 poolsar42 requested a review from maurerbot May 30, 2023 17:08
@maurerbot
Copy link
Contributor

Please add projects ids from 1pass

@poolsar42
Copy link
Collaborator Author

Please add projects ids from 1pass

@maurerbot
You mean these?
https://github.com/proofzero/rollupid/pull/2319/files#diff-89b0663d5c37a3746733a0daee4c0c0e000d4a30d2e2bbb1ca8ab3eb16841813

https://github.com/proofzero/rollupid/pull/2319/files#diff-d3f9a28f38f468184fd38d7007486871cf770ae7f7756e1c2f33a44989d68425

@maurerbot maurerbot merged commit 10aa99d into main May 30, 2023
15 of 16 checks passed
@maurerbot maurerbot deleted the chore/2303-upgrade-connect-kit-and-wagmi branch May 30, 2023 19:19
maurerbot added a commit that referenced this pull request May 31, 2023
@maurerbot
Revert "chore(apps): upgrade connectkit and wagmi (#2319)"
d4e6436 
This reverts commit 10aa99d.
@maurerbot maurerbot mentioned this pull request May 31, 2023
Merged
betimshahini pushed a commit that referenced this pull request May 31, 2023
@maurerbot
Revert "chore(apps): upgrade connectkit and wagmi (#2319)" (#2346)
a4e47df 
This reverts commit 10aa99d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurerbot maurerbot maurerbot approved these changes

Assignees

@poolsar42 poolsar42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(apps): upgrade connect kit and wagmi
3 participants
@poolsar42 @maurerbot @betimshahini