chore(platform): Add multi-wallet selection support to authz screen #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poolsar42
force-pushed
the
chore/2218-platform-multiselect-authz-screen-support
branch
from
e4b5a61
to
04adc1c
Compare
betimshahini
requested changes
May 29, 2023
|
|
||
| } | ||
|
|
||
| export const modifyType = (string: string) => { |
There was a problem hiding this comment.
Name this something a lot more descriptive. Seems like it's doing a very small thing, yet it has a very generic name.
| @@ -88,7 +85,11 @@ export const getDataForScopes = async ( | |||
| const addressClient = getAddressClient(ca.baseUrn, env, traceSpan) | |||
| return addressClient.getAddressProfile.query() | |||
| }) | |||
| ) | |||
| )).map(address => ({ | |||
There was a problem hiding this comment.
Looks like this code is very similar to getNormalizedSmartContractWallet(). Can we make this a generic function? If not, refactor this code and move it into utils like the others, and call it from here.
maurerbot
previously requested changes
May 29, 2023
poolsar42
force-pushed
the
chore/2218-platform-multiselect-authz-screen-support
branch
from
584dd31
to
f60c3f9
Compare
poolsar42
force-pushed
the
chore/2218-platform-multiselect-authz-screen-support
branch
from
f60c3f9
to
0b2f5f9
Compare
poolsar42
force-pushed
the
chore/2218-platform-multiselect-authz-screen-support
branch
from
0b2f5f9
to
e7cd408
Compare
betimshahini
approved these changes
Jun 1, 2023
betimshahini
deleted the
chore/2218-platform-multiselect-authz-screen-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Injects "Dropdown" component into Authz screen with generic dropdown for sc_wallets emails and connected accounts.
Updates the same component for email selection in console
Related Issues
Testing
Manually going to all mentioned routes (authz screen, teams in console)
Checklist