Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(console): Temp fix for email selection in Team and contacts #2354

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

betimshahini
Copy link
Contributor

Description

Temporary hotfix for issue where selection of email in Team and contacts page in Console would have no effect.

This will be followed up with a full fix, dealing with typescript types primarily, at a later point.

Related Issues

Testing

  • Team and contacts page selection now saves. Toast message shows up as well.
  • Email selection in authz screen works as previously.

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temp fix. Some things to consider:

  • Add address urn space check
  • Cast value as string, that way we can do a single ts-ignore at cast line

@betimshahini betimshahini marked this pull request as ready for review June 2, 2023 08:00
@betimshahini betimshahini merged commit 4b16bc7 into main Jun 2, 2023
12 checks passed
@betimshahini betimshahini deleted the fix/2352-temp-fix branch June 2, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants