feat(console): DNS validation for custom domain CNAME records. #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkl
previously approved these changes
Jun 2, 2023
szkl
reviewed
Jun 5, 2023
packages/utils/errors.ts
Outdated
| @@ -87,6 +92,7 @@ const getErrorFromTRPCClientError = (error: any): Error => { | |||
| } | |||
| } else if (error.data && 'zodError' in error.data) { | |||
| const cause = (error.data as { zodError: object }).zodError | |||
| console.debug('ZOD', cause) | |||
szkl
reviewed
Jun 5, 2023
Comment on lines
+274
to
+276
| for (const dnsRec of stored.dns_records) { | ||
| dnsRec.value = await getDNSRecordValue(dnsRec.name, dnsRec.record_type) | ||
| } |
There was a problem hiding this comment.
Would this block need exception handling?
There was a problem hiding this comment.
Same as other comment.
szkl
previously approved these changes
Jun 5, 2023
szkl
reviewed
Jun 5, 2023
Comment on lines
+64
to
+66
| for (const dnsRec of stored.dns_records) { | ||
| dnsRec.value = await getDNSRecordValue(dnsRec.name, dnsRec.record_type) | ||
| } |
There was a problem hiding this comment.
Would this block need exception handling?
There was a problem hiding this comment.
As per convo, it would get picked up by the next alarm run until it eventually validates fully. Any errors will propagate up to the caller in Console, which will log for visibility.
szkl
approved these changes
Jun 5, 2023
poolsar42
pushed a commit
that referenced
this pull request
Jun 5, 2023
* DNS validation for custom domain CNAME records. * Custom domain validation includes CNAME validation * Removed unnecessary debug statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds indicator for validating CNAME records on the custom domain page. CNAME validitiy check is now included as part of the custom domain validity indicator on the page. The same is done in Passport to check whether custom domain is active.
Related Issues
Testing
Checklist