-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): Designer - Login tab tweaks #2359
Conversation
921f310
to
242f388
Compare
@@ -387,6 +414,25 @@ const AuthPanel = ({ | |||
|
|||
<div className="w-full border-b border-gray-200"></div> | |||
|
|||
<FormElement label="Wallet Signature Request Sign Message"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
This will not trigger a blockchain transaction or cost any gas fees. | ||
|
||
{{nonce}}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the text is now user-configurable, it's open to funky injection and misconfiguration issues. The nonce is gonna have to be removed from the template itself and injected programatically in the code itself, such that a user isn't able to mimick it in the message content itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appended the nonce template after message.
6908c0d
to
85333a8
Compare
6c4fb49
to
ef0b3f8
Compare
ef0b3f8
to
6122c3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing: Reset to default link takes the colour from the configured primary colour, depending on whether dark mode toggle is on or off. This should use the rollup primary colours.
Description
primary-alt
button bg color borrowed from designer settingsprimary-alt
button text color computed via contrast helpersRelated Issues
Testing
Checklist