Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): Designer - Login tab tweaks #2359

Merged
merged 12 commits into from
Jun 8, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Jun 5, 2023

Description

  • Added sign message template to customizable fields in designer
  • Added reset to default action to designer
  • Added primary-alt button bg color borrowed from designer settings
  • Added primary-alt button text color computed via contrast helpers
image image

Related Issues

Testing

  • Visually in designer
  • Visually in passport flow
  • Visually in profile flow

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jun 5, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Jun 5, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review June 5, 2023 12:33
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/designer-login-tab-tweaks branch from 921f310 to 242f388 Compare June 6, 2023 07:07
@@ -387,6 +414,25 @@ const AuthPanel = ({

<div className="w-full border-b border-gray-200"></div>

<FormElement label="Wallet Signature Request Sign Message">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Default size of text area is too small (tested on Firefox)
  2. Font size of content in text area is bigger than that of the other input elements
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Updated default size to 5 rows
  2. Updated input textarea font size
image


This will not trigger a blockchain transaction or cost any gas fees.

{{nonce}}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the text is now user-configurable, it's open to funky injection and misconfiguration issues. The nonce is gonna have to be removed from the template itself and injected programatically in the code itself, such that a user isn't able to mimick it in the message content itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appended the nonce template after message.

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/designer-login-tab-tweaks branch 2 times, most recently from 6908c0d to 85333a8 Compare June 7, 2023 07:38
@betimshahini
Copy link
Contributor

Just noticing now:

  1. Colour of Save button top-right also takes the primary colour.
  2. Name of the application in the second slide of the previewer says Passport. This should take the name of the app from OAuth page
image

FYI, still thinking about the nonce template solution. As implemented, there's still potential concerns with it, but they might not materialize due to what we do downstream during nonce verification.

@Cosmin-Parvulescu
Copy link
Contributor Author

Cosmin-Parvulescu commented Jun 7, 2023

Just noticing now:

  1. Colour of Save button top-right also takes the primary colour.

I sort of liked that, maybe that's why I'm not a designer 😅

  1. Name of the application in the second slide of the previewer says Passport. This should take the name of the app from OAuth page

Updated this.

image

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/designer-login-tab-tweaks branch from 6c4fb49 to ef0b3f8 Compare June 7, 2023 14:52
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/designer-login-tab-tweaks branch from ef0b3f8 to 6122c3b Compare June 7, 2023 14:59
Copy link
Contributor

@betimshahini betimshahini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing: Reset to default link takes the colour from the configured primary colour, depending on whether dark mode toggle is on or off. This should use the rollup primary colours.

@Cosmin-Parvulescu
Copy link
Contributor Author

One last thing: Reset to default link takes the colour from the configured primary colour, depending on whether dark mode toggle is on or off. This should use the rollup primary colours.

This one saddens me the most :(

image

@betimshahini betimshahini merged commit 2f3e87c into main Jun 8, 2023
14 of 16 checks passed
@betimshahini betimshahini deleted the feat/console/designer-login-tab-tweaks branch June 8, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(console): Designer - Login tab tweaks
2 participants