Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(passport): connect oauth proxy #2364

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

szkl
Copy link
Contributor

@szkl szkl commented Jun 5, 2023

Description

Implements a process to set custom domain host as the request origin and
redirects to the default host for the usual OAuth authorization. The origin is
then used to redirect back OAuth callback request back to the custom domain
host.

The state generated by remix-auth-oauth2 is exchanged between the custom
domain and the default host.

Related Issues

Testing

  • Manual

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@szkl szkl marked this pull request as draft June 5, 2023 19:20
@szkl szkl self-assigned this Jun 5, 2023
@szkl szkl added the enhancement Indicates new feature requests label Jun 5, 2023
@szkl szkl force-pushed the feat/passport/proxy-oauth branch 5 times, most recently from fe61ddc to c183699 Compare June 6, 2023 14:54
@szkl szkl marked this pull request as ready for review June 6, 2023 14:57
@szkl szkl force-pushed the feat/passport/proxy-oauth branch from c183699 to ac143d3 Compare June 6, 2023 16:19
@szkl szkl force-pushed the feat/passport/proxy-oauth branch from ac143d3 to c12d4b6 Compare June 6, 2023 16:29
@betimshahini betimshahini merged commit fe91610 into main Jun 6, 2023
12 checks passed
@betimshahini betimshahini deleted the feat/passport/proxy-oauth branch June 6, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(passport): Use Rollup creds for OAuth logins when custom domain configured
2 participants