Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starbase): Fix in validation logic of custom domains in getAppPublicProps #2367

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

betimshahini
Copy link
Contributor

Description

Fix in validation logic of custom domains in getAppPublicProps, where it wouldn't return a boolean value in the evaluation expression, but undefined or null. Without the fix, errors are thrown for cases of a non-custom domain lookup.

Related Issues

  • N/A

Testing

  • Invoked functionality that looks up AppProps (by logging on to an app). Was able to successfully get to the login page.

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@betimshahini betimshahini marked this pull request as ready for review June 6, 2023 07:59
@betimshahini betimshahini merged commit e8d4380 into main Jun 6, 2023
12 checks passed
@betimshahini betimshahini deleted the fix/custom-domain-appprops-validation-fix branch June 6, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants