Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(passport): User able to disconnect the wallet and still sign in using the earlier triggered MetaMask notification #2393

Merged
merged 2 commits into from
Jun 12, 2023
Merged

fix(passport): User able to disconnect the wallet and still sign in using the earlier triggered MetaMask notification #2393

merged 2 commits into from
Jun 12, 2023

Conversation

poolsar42
Copy link
Collaborator

Description

Disables "disconnect" button when user is prompted to sing a message with wallet.

Related Issues

Testing

  1. Goto passport authn page
  2. Select the option 'Connect with Wallet'
  3. Select 'MetaMask' in the Connect Wallet-pop up
  4. Connect a wallet and once connected click the 'Continue with <wallet_address>' button
  5. Once the 'MetaMask Notification' window is displayed, try disconnecting the wallet and click 'Sign' on the MetaMask notification window.

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@maurerbot maurerbot merged commit ad88012 into main Jun 12, 2023
13 of 14 checks passed
@maurerbot maurerbot deleted the fix/2288-disconnect-not-allowed-when-metamask-triggered branch June 12, 2023 17:52
@poolsar42 poolsar42 self-assigned this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurerbot maurerbot maurerbot approved these changes

Assignees

@poolsar42 poolsar42

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@poolsar42 @maurerbot