Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(passport): loading transition not shown when logging in with social #2396

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

poolsar42
Copy link
Collaborator

Description

Returns Loading component back when loggin-in with non-blockchain oauth providers.

Related Issues

Testing

Was trying to log in with all providers in passport

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@maurerbot maurerbot merged commit 7a3b1f0 into main Jun 12, 2023
10 of 11 checks passed
@maurerbot maurerbot deleted the fix/2395-passport-loading-transition-authn-screen branch June 12, 2023 21:04
@poolsar42 poolsar42 self-assigned this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(passport): loading transition not shown when logging in with social
2 participants