fix(passport): displaying app's favicon in custom domain #2418
Conversation
apps/passport/app/root.tsx
Outdated
| @@ -90,6 +93,25 @@ export const loader: LoaderFunction = getRollupReqFunctionErrorWrapper( | |||
| return redirect(`/authenticate`) | |||
| } | |||
|
|
|||
| let appProps: GetAppPublicPropsResult | |||
There was a problem hiding this comment.
is this not already in context?
There was a problem hiding this comment.
@maurerbot nope
{
context: {
authzQueryParams: {
clientId: '',
state: '',
redirectUri: '',
scope: [],
prompt: undefined,
login_hint: undefined,
rollup_action: undefined,
rollup_result: undefined
},
env: ServiceWorkerGlobalScope {},
traceSpan: TraceSpan {
traceId: '70c7e789dfcd23ea82eecac91c7aaf53',
spanId: 'a0c0d5b6de5115dd',
startTime: 1686932216223
}
}
}There was a problem hiding this comment.
we must be checking for custom domain somewhere and pulling in appdata?
There was a problem hiding this comment.
All things wee need to fetch appData is clientId. In custom domains it is being provided if I recall correctly and we tested its validity for custom domain with @szkl recently
There was a problem hiding this comment.
Here's the check for clientId
There was a problem hiding this comment.
Haha its done actually take a look here
poolsar42
force-pushed
the
fix/2406-favicon-in-mematask-for-cutom-domain
branch
from
e880ca6
to
5193eed
Compare
poolsar42
force-pushed
the
fix/2406-favicon-in-mematask-for-cutom-domain
branch
from
5193eed
to
0cd280a
Compare
|
The commit message should be about the changes in the pull request. |
poolsar42
changed the title
poolsar42
force-pushed
the
fix/2406-favicon-in-mematask-for-cutom-domain
branch
from
2455979
to
9f30f17
Compare
apps/passport/app/root.tsx
Outdated
| @@ -78,6 +81,32 @@ export const links: LinksFunction = () => [ | |||
|
|
|||
| export const loader: LoaderFunction = getRollupReqFunctionErrorWrapper( | |||
| async ({ request, context, params }) => { | |||
| let appProps: GetAppPublicPropsResult | |||
|
|
|||
| if (context?.authzQueryParams?.app_props) { | |||
There was a problem hiding this comment.
can't we assume it will always be there? if it's not it is probably console or passport?
| @@ -90,6 +95,7 @@ const handleEvent = async (event: FetchEvent) => { | |||
|
|
|||
| try { | |||
| const app = await starbaseClient.getAppPublicProps.query({ clientId }) | |||
There was a problem hiding this comment.
why not skip if passport or console?
There was a problem hiding this comment.
Line 84 checks for a custom domain request. If it is a custom domain request then there's a clientId.
poolsar42
changed the title
Description
App's favicon on now displayed on the MetaMask Notification window
Loader in passport now reflects colours that were set in designer for specific app
Fixes bugs with redirects in passport which were not indicated in any other issues, stable temporary solution for
/signroute when there's an error occurs. Solves issue with/authenticateroute to not redirect to/settings/dashboardlogged-in users.Fetches appProps from starbase before loading context and puts it in the context object.
Related Issues
Testing
Go to authn screen and pop-up metamask window to sign a message. Under custom domain or just with clientId for the specific app.
Checklist