Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(platform): Extend worker interfaces for batch operations #2419

Merged
merged 7 commits into from
Jun 16, 2023

Conversation

betimshahini
Copy link
Contributor

@betimshahini betimshahini commented Jun 16, 2023

Description

Adds batch interfaces and leverages them for specific "hot paths". The following now have batch variants that take an array of the same type as the non-batch variant.

  • Address worker's getAddressProfile()
  • Edge worker's findNode()
  • Starbase worker's getAppPublicProps()

To get around our previous design choice of having an AddressURN be needed for the construction of the Address client, this also introduces a no-op placeholder AddressURN that can be used to initalize a client, so that the batch interfaces (with multiple AddressURNs) can be leveraged.

Also removes ENS lookups for smart contract wallets, due to the worker subrequest multiplication for contract addresses.

Note: getAuthorizedAppScopes() will get addressed as part of bigger effort under #2013

Related Issues

Testing

  • Authz screen with previous pre-selection for the connectec accounts.
  • Passport settings screen for connected accounts
  • Application Claims view for connected accounts
  • Being able to load the app with 40+ accounts

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@betimshahini betimshahini changed the title Fix/2215-worker-batch-ops chore(platform): Extend worker interfaces for batch operations Jun 16, 2023
@betimshahini betimshahini marked this pull request as ready for review June 16, 2023 11:19
@betimshahini betimshahini marked this pull request as draft June 16, 2023 11:29
@betimshahini betimshahini marked this pull request as ready for review June 16, 2023 13:18
@maurerbot maurerbot merged commit 6604eb7 into main Jun 16, 2023
12 checks passed
@maurerbot maurerbot deleted the fix/2215-worker-batch-ops branch June 16, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants