Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(console): Add billing email selection dropdown #2439

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Jun 23, 2023

Description

  • Added edge Account -> Address to represent billing e-mail address associated to an account
  • Added checks when deleting addresses in passport

Related Issues

Testing

  1. Add e-mail to billing
  2. Go to passport
  3. Try to delete account
  4. Go back to console
  5. Update address
  6. Go back to passport
  7. Try to delete

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Jun 23, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jun 23, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review June 23, 2023 11:23
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the chore/console/add-billing-email-selection-dropdown branch from a9bbb1b to 6831bf2 Compare June 26, 2023 07:49
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the chore/console/add-billing-email-selection-dropdown branch from 6831bf2 to fc1ab89 Compare June 26, 2023 11:31
},
})

if (edges.length > 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a way to upsert? cc @betimshahini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maurerbot First-time (t=1) upsert is there, but the removal of what's already there (in the case of updates where t>1) is not. This is the best we have the facilities to do for now.

@maurerbot maurerbot merged commit 0d15278 into main Jun 26, 2023
12 checks passed
@maurerbot maurerbot deleted the chore/console/add-billing-email-selection-dropdown branch June 26, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(console): Add billing email selection dropdown
3 participants