chore(console): Enable custom domains and designer after paid plans implementation #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmin-Parvulescu
force-pushed
the
chore/console/enable-custom-domains-and-designer-after-paid-plans-implementation
branch
from
501c621
to
2ab1268
Compare
betimshahini
requested changes
Jul 13, 2023
| import { ToastType } from '@proofzero/design-system/src/atoms/toast' | ||
| import { commitFlashSession } from '~/utilities/session.server' | ||
|
|
||
| const isPlanGuarded = async ( |
There was a problem hiding this comment.
This doesn't need to be async. Likewise, no need to await it in the function below.
| @@ -984,7 +984,7 @@ export default () => { | |||
| }), | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
This button disappears when entering the details (name and email), but is still clickable.
There was a problem hiding this comment.
May be a local setup thing on my side as others can't reproduce. Proceeding.
betimshahini
approved these changes
Jul 13, 2023
| @@ -984,7 +984,7 @@ export default () => { | |||
| }), | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
May be a local setup thing on my side as others can't reproduce. Proceeding.
betimshahini
deleted the
chore/console/enable-custom-domains-and-designer-after-paid-plans-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Testing
Testing in dev
Checklist