Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(console): Removing purchased entitlements needs guard rails #2495

Merged
merged 1 commit into from
Jul 18, 2023
Merged

feat(console): Removing purchased entitlements needs guard rails #2495

merged 1 commit into from
Jul 18, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Jul 14, 2023 •
edited
Loading

Description

  • Added server side checks for pro plan entitlement quantity vs. update quantity
  • Fixed some typos
  • Aligned with figma design
  • Disable button if invalid case is selected

Related Issues

Testing

  • Removed apps
  • Added apps

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the bug Indicates an unexpected problem or unintended behavior label Jul 14, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jul 14, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu added enhancement Indicates new feature requests and removed bug Indicates an unexpected problem or unintended behavior labels Jul 14, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review July 14, 2023 10:22
betimshahini
betimshahini reviewed Jul 14, 2023
View reviewed changes
apps/console/app/routes/__layout/billing/index.tsx Outdated
).length
if (assignedEntitlementCount > quantity) {
throw new BadRequestError({
message: `Invalid quantity. Downgrade ${
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To future-proof this, when other plans are introduced, change 'Downgrade' to 'Change'

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/removing-purchased-entitlements-needs-guard-rails branch from c9be561 to 70bb670 Compare July 17, 2023 08:38
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the feat/console/removing-purchased-entitlements-needs-guard-rails branch from 70bb670 to e2fa671 Compare July 18, 2023 08:33
@betimshahini betimshahini merged commit a19708e into main Jul 18, 2023
12 checks passed
@betimshahini betimshahini deleted the feat/console/removing-purchased-entitlements-needs-guard-rails branch July 18, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini betimshahini approved these changes

@maurerbot maurerbot Awaiting requested review from maurerbot

@szkl szkl Awaiting requested review from szkl

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(console): Removing purchased entitlements needs guard rails
2 participants
@Cosmin-Parvulescu @betimshahini