fix(console): Billing email #2512
Conversation
Cosmin-Parvulescu
added
the
bug
Cosmin-Parvulescu
force-pushed
the
fix/console/billing
branch
2 times, most recently
from
a1cd485
to
0f8f91d
Compare
| inferredAddressURN = targetAddress?.baseUrn as AddressURN | ||
|
|
||
| if (!inferredAddressURN) { | ||
| throw new RollupError({ |
There was a problem hiding this comment.
Use an error with an HTTP status code, like BadRequestError or InternalServerError
There was a problem hiding this comment.
Addressed
| (address) => address.qc.alias.toLowerCase() === spd.email.toLowerCase() | ||
| ) | ||
|
|
||
| if (!targetAddress) { |
There was a problem hiding this comment.
Same comment as above.
There was a problem hiding this comment.
Same resolution as above. 😁
| // addressURN | ||
| let inferredAddressURN | ||
| if (!paymentData.addressURN) { | ||
| const addresses = await accountClient.getAddresses.query({ |
There was a problem hiding this comment.
Extract this bit of code into something like a getAddressURNFromEmail() function, so it can also be used in index.tsx.
There was a problem hiding this comment.
Added a method to the address router.
| @@ -29,47 +29,55 @@ export const action: ActionFunction = getRollupReqFunctionErrorWrapper( | |||
| }) | |||
There was a problem hiding this comment.
Should this also do the lookup from email to address? I keep getting Bad Request: AddressURNInput is not a string: undefined when trying to update my stripe info from the details page.
There was a problem hiding this comment.
It was an oversight in loading the default addressURN, the problem was addressed without needing to lookup address from email.
Cosmin-Parvulescu
force-pushed
the
fix/console/billing
branch
from
0f8f91d
to
0368ed2
Compare
Description
Related Issues
Testing
Checklist