Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): Can't delete app from dashboard #2569

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix(console): Can't delete app from dashboard #2569

merged 1 commit into from
Aug 2, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

Description

  • Updated Delete App Modal props to take a subset of app details
  • Updated application list items

Related Issues

Testing

Scenario 1

  • Create new app
  • Delete app from /auth endpoint

Scenario 2

  • Create new app
  • Delete app from application list context menu

Scenario 3

  • Create new app
  • Add custom domain
  • Try to delete app
  • See message
  • Remove custom domain
  • Delete app
  • Get foreign key error

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the bug Indicates an unexpected problem or unintended behavior label Aug 2, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Aug 2, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the fix/console/can't-delete-app-from-dashboard branch from 9d2c9dc to 7511019 Compare August 2, 2023 12:45
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the fix/console/can't-delete-app-from-dashboard branch from 7511019 to 886ac10 Compare August 2, 2023 12:47
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review August 2, 2023 12:49
@betimshahini betimshahini merged commit 5002e0f into main Aug 2, 2023
13 of 14 checks passed
@betimshahini betimshahini deleted the fix/console/can't-delete-app-from-dashboard branch August 2, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini betimshahini approved these changes

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(console): Can't delete app from dashboard
2 participants
@Cosmin-Parvulescu @betimshahini