feat(console|passport): Delete group, delete member and identity of group member #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmin-Parvulescu
force-pushed
the
feat/console|passport/delete-group,-delete-member-and-identity-of-group-member
branch
3 times, most recently
from
c2fcf2a
to
9e23d47
Compare
betimshahini
requested changes
Aug 14, 2023
| }: { | ||
| ctx: Context | ||
| }): Promise<void> => { | ||
| if (!ctx.accountURN) { |
There was a problem hiding this comment.
Replace this with the RequireAccount middleware. Same for the other methods.
| }) | ||
| } | ||
|
|
||
| const purge = Boolean(fd.get('purge')) |
There was a problem hiding this comment.
Move this up so it runs before the FormData parse .. securitah!!
|
|
||
| const identityGroupURNList = edges.map((e) => e.dst.baseUrn) | ||
| await Promise.all( | ||
| identityGroupURNList.map(async (igu) => { |
There was a problem hiding this comment.
This, ideally, we'd push down into edges to be done in a single call but maybe this may not be the right PR for it. Give it a think if it can be "easily" added and we'll decide together.
Cosmin-Parvulescu
force-pushed
the
feat/console|passport/delete-group,-delete-member-and-identity-of-group-member
branch
from
bdb1edf
to
7f17ff6
Compare
betimshahini
approved these changes
Aug 15, 2023
betimshahini
deleted the
feat/console|passport/delete-group,-delete-member-and-identity-of-group-member
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Testing
--
--
--
--
Checklist