Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): Billing seat bugs #2779

Merged
merged 4 commits into from
Nov 30, 2023
Merged

fix(console): Billing seat bugs #2779

merged 4 commits into from
Nov 30, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Nov 30, 2023 •
edited
Loading

Description

  • Removed client side sorting from invoice table
  • Updated UI to display credits
  • Added individual requests for the customer / subscription combination when aggregating invoices
  • Updated source of truth for upcoming interface amounts & due dates
  • Added server side check when accepting an invitation when group is already full

Related Issues

Testing

  • Stripe backend / console bff / console alignment, interface testing, console logs, visual etc.
  • Create new group, add 3 members, buy seat, invite 4th member, downgrade seat count in stripe dashboard, try to accept invitation, get error

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the bug Indicates an unexpected problem or unintended behavior label Nov 30, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Nov 30, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review November 30, 2023 19:53
@betimshahini betimshahini merged commit c143466 into main Nov 30, 2023
14 checks passed
@betimshahini betimshahini deleted the fix/console/Billing-seat-bugs branch November 30, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini betimshahini approved these changes

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(console): Billing seat bugs
2 participants
@Cosmin-Parvulescu @betimshahini