fix(urns): pass NID and NSS to base class type parameters
#2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkl
changed the title
NID and NSS to base class type parameters
szkl
force-pushed
the
fix/urns/typed-components-urn-space
branch
from
03bbdd4
to
10bd3aa
Compare
szkl
force-pushed
the
fix/urns/typed-components-urn-space
branch
from
10bd3aa
to
6871232
Compare
szkl
force-pushed
the
fix/urns/typed-components-urn-space
branch
from
6871232
to
00c6ddd
Compare
szkl
force-pushed
the
fix/urns/typed-components-urn-space
branch
2 times, most recently
from
a6b26fd
to
49147f3
Compare
‘URNSpace’ base class methods were using ‘string‘ type by default which was preventing type inference that would be achieved by predicate methods like ‘URNSpace.is’.
szkl
force-pushed
the
fix/urns/typed-components-urn-space
branch
from
49147f3
to
4dbe0dd
Compare
betimshahini
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URNSpacebase class methods were usingstringtype by defaultwhich was preventing type inference that would be achieved by
predicate methods like
URNSpace.is.