Adjustments for prooph/event-store v6 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @prolic |
| * @param object $anEventSourcedAggregateRoot | ||
| * @param Message[] $events | ||
| */ | ||
| public function applyPendingStreamEvents($anEventSourcedAggregateRoot, array $events) |
There was a problem hiding this comment.
This is the only method that wants an array instead of an iterator. What would you think of making this consistent with the other methods?
To achieve this, we would do in the AggregateRootDecorator this:
public function extractRecordedEvents(AggregateRoot $anAggregateRoot)
{
return new \ArrayIterator($anAggregateRoot->popRecordedEvents());
}
Also update the ConfigurableAggregateTranslator and the AggregateRepository classes.
On the other hand, it' not really needed, but the methods here would have consistent method headers.
There was a problem hiding this comment.
Like discussed yesterday in the chat I think we can keep it as-is. The \Iterator type hint represents the event stream and the array type hint says that the given events are not the stream but only the current pending events.
@prolic What do you think?
prolic
added a commit
that referenced
this pull request
Sep 30, 2015
Adjustments for prooph/event-store v6
|
accepted :) |
|
great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.