Merge f8346df into 7bfe9bd

prooph · Nov 28, 2020 · 4cd5cec · 4cd5cec
2 parents 7bfe9bd + f8346df
commit 4cd5cec
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 4 deletions.
diff --git a/tests/EventStoreConnectionTestCase.php b/tests/EventStoreConnectionTestCase.php
@@ -31,7 +31,7 @@ protected function setUpAsync(): Generator
 
     protected function tearDownAsync(): Generator
     {
-        //$this->connection->close();
+        $this->connection->close();
 
         yield new Success();
     }

diff --git a/tests/PersistentSubscriptionManagement/persistent_subscription_manager.php b/tests/PersistentSubscriptionManagement/persistent_subscription_manager.php
@@ -96,6 +96,13 @@ protected function when(): Generator
         );
     }
 
+    protected function end(): Generator
+    {
+        $this->sub->stop();
+
+        yield new Success();
+    }
+
     /** @test */
     public function can_describe_persistent_subscription(): Generator
     {

diff --git a/tests/Security/AuthenticationTestCase.php b/tests/Security/AuthenticationTestCase.php
@@ -161,7 +161,7 @@ protected function setUpAsync(): Generator
     protected function tearDownAsync(): Generator
     {
         $this->userCredentials = null;
-        //$this->connection->close();
+        $this->connection->close();
 
         $manager = new UsersManager(
             TestConnection::httpEndPoint(),

diff --git a/tests/SpecificationWithConnection.php b/tests/SpecificationWithConnection.php
@@ -56,7 +56,7 @@ protected function execute(Closure $test): Promise
 
     protected function end(): Generator
     {
-        //$this->connection->close();
+        $this->connection->close();
 
         yield new Success();
     }

diff --git a/tests/catch_up_subscription_handles_small_batch_sizes.php b/tests/catch_up_subscription_handles_small_batch_sizes.php
@@ -50,6 +50,13 @@ protected function setUpAsync(): Generator
         $this->settings = new CatchUpSubscriptionSettings(100, 1, false, true);
     }
 
+    protected function tearDownAsync(): Generator
+    {
+        $this->connection->close();
+
+        yield new Success();
+    }
+
     /** @return EventData[] */
     private function createOneHundredEvents(): array
     {

diff --git a/tests/connect_to_existing_persistent_subscription_with_max_one_client.php b/tests/connect_to_existing_persistent_subscription_with_max_one_client.php
@@ -99,6 +99,13 @@ function (
         }
     }
 
+    protected function end(): Generator
+    {
+        $this->connection->close();
+
+        yield new Success();
+    }
+
     /** @test */
     public function the_first_subscription_connects_successfully(): Generator
     {

diff --git a/tests/connect_to_existing_persistent_subscription_with_permissions.php b/tests/connect_to_existing_persistent_subscription_with_permissions.php
@@ -61,8 +61,15 @@ protected function when(): Generator
         );
     }
 
+    protected function end(): Generator
+    {
+        $this->connection->close();
+
+        yield new Success();
+    }
+
     /** @test */
-    public function the_subscription_suceeds(): Generator
+    public function the_subscription_succeeds(): Generator
     {
         yield $this->execute(function (): Generator {
             $this->assertNotNull(yield $this->sub);