Merge pull request #12 from prooph/noooooooo

I DO NOT WANT TO DO THIS, UPPERCASE IS UTTERLY STUPID

examples/demo-async-cluster.php

@@ -66,7 +66,7 @@
 
     \var_dump($m);
 
-    $r = yield $connection->setStreamMetadataAsync('foo-bar', ExpectedVersion::Any, new StreamMetadata(
+    $r = yield $connection->setStreamMetadataAsync('foo-bar', ExpectedVersion::ANY, new StreamMetadata(
         null, null, null, null, null, [
             'foo' => 'bar',
         ]
@@ -78,7 +78,7 @@
 
     \var_dump($m);
 
-    $wr = yield $connection->appendToStreamAsync('foo-bar', ExpectedVersion::Any, [
+    $wr = yield $connection->appendToStreamAsync('foo-bar', ExpectedVersion::ANY, [
         new EventData(EventId::generate(), 'test-type', false, 'jfkhksdfhsds', 'meta'),
         new EventData(EventId::generate(), 'test-type2', false, 'kldjfls', 'meta'),
         new EventData(EventId::generate(), 'test-type3', false, 'aaa', 'meta'),

examples/demo-async-dns-cluster.php

@@ -63,7 +63,7 @@
 
     \var_dump($m);
 
-    $r = yield $connection->setStreamMetadataAsync('foo-bar', ExpectedVersion::Any, new StreamMetadata(
+    $r = yield $connection->setStreamMetadataAsync('foo-bar', ExpectedVersion::ANY, new StreamMetadata(
         null, null, null, null, null, [
             'foo' => 'bar',
         ]
@@ -75,7 +75,7 @@
 
     \var_dump($m);
 
-    $wr = yield $connection->appendToStreamAsync('foo-bar', ExpectedVersion::Any, [
+    $wr = yield $connection->appendToStreamAsync('foo-bar', ExpectedVersion::ANY, [
         new EventData(EventId::generate(), 'test-type', false, 'jfkhksdfhsds', 'meta'),
         new EventData(EventId::generate(), 'test-type2', false, 'kldjfls', 'meta'),
         new EventData(EventId::generate(), 'test-type3', false, 'aaa', 'meta'),

examples/demo-async-with-logger.php

@@ -62,7 +62,7 @@
 
     \var_dump(\get_class($m));
 
-    $r = yield $connection->setStreamMetadataAsync('foo-bar', ExpectedVersion::Any, new StreamMetadata(
+    $r = yield $connection->setStreamMetadataAsync('foo-bar', ExpectedVersion::ANY, new StreamMetadata(
         null, null, null, null, null, [
             'foo' => 'bar',
         ]
@@ -74,7 +74,7 @@
 
     \var_dump(\get_class($m));
 
-    $wr = yield $connection->appendToStreamAsync('foo-bar', ExpectedVersion::Any, [
+    $wr = yield $connection->appendToStreamAsync('foo-bar', ExpectedVersion::ANY, [
         new EventData(EventId::generate(), 'test-type', false, 'jfkhksdfhsds', 'meta'),
         new EventData(EventId::generate(), 'test-type2', false, 'kldjfls', 'meta'),
         new EventData(EventId::generate(), 'test-type3', false, 'aaa', 'meta'),

examples/demo-async.php

@@ -57,7 +57,7 @@
 
     \var_dump($m);
 
-    $r = yield $connection->setStreamMetadataAsync('foo-bar', ExpectedVersion::Any, new StreamMetadata(
+    $r = yield $connection->setStreamMetadataAsync('foo-bar', ExpectedVersion::ANY, new StreamMetadata(
         null, null, null, null, null, [
             'foo' => 'bar',
         ]
@@ -69,7 +69,7 @@
 
     \var_dump($m);
 
-    $wr = yield $connection->appendToStreamAsync('foo-bar', ExpectedVersion::Any, [
+    $wr = yield $connection->appendToStreamAsync('foo-bar', ExpectedVersion::ANY, [
         new EventData(EventId::generate(), 'test-type', false, 'jfkhksdfhsds', 'meta'),
         new EventData(EventId::generate(), 'test-type2', false, 'kldjfls', 'meta'),
         new EventData(EventId::generate(), 'test-type3', false, 'aaa', 'meta'),

examples/demo-sync.php

@@ -52,7 +52,7 @@
 
 \var_dump($m);
 
-$wr = $connection->appendToStream('foo-bar', ExpectedVersion::Any, [
+$wr = $connection->appendToStream('foo-bar', ExpectedVersion::ANY, [
     new EventData(EventId::generate(), 'test-type', false, 'jfkhksdfhsds', 'meta'),
     new EventData(EventId::generate(), 'test-type2', false, 'kldjfls', 'meta'),
     new EventData(EventId::generate(), 'test-type3', false, 'aaa', 'meta'),

src/CatchUpSubscriptionSettings.php

@@ -56,10 +56,10 @@ public function __construct(
             throw new InvalidArgumentException('Max live queue size must be positive');
         }
 
-        if ($readBatchSize > Consts::MaxReadSize) {
+        if ($readBatchSize > Consts::MAX_READ_SIZE) {
             throw new InvalidArgumentException(\sprintf(
                 'Read batch size should be less than \'%s\'. For larger reads you should page',
-                Consts::MaxReadSize
+                Consts::MAX_READ_SIZE
             ));
         }
 
@@ -73,8 +73,8 @@ public function __construct(
     public static function default(): self
     {
         return new self(
-            Consts::CatchUpDefaultMaxPushQueueSize,
-            Consts::CatchUpDefaultReadBatchSize,
+            Consts::CATCH_UP_DEFAULT_MAX_PUSH_QUEUE_SIZE,
+            Consts::CATCH_UP_DEFAULT_READ_BATCH_SIZE,
             false,
             true,
             ''

src/ClientOperations/AbstractOperation.php

@@ -105,11 +105,11 @@ public function inspectPackage(TcpPackage $package): InspectionResult
         }
 
         switch ($package->command()->value()) {
-            case TcpCommand::NotAuthenticatedException:
+            case TcpCommand::NOT_AUTHENTICATED_EXCEPTION:
                 return $this->inspectNotAuthenticated($package);
-            case TcpCommand::BadRequest:
+            case TcpCommand::BAD_REQUEST:
                 return $this->inspectBadRequest($package);
-            case TcpCommand::NotHandled:
+            case TcpCommand::NOT_HANDLED:
                 return $this->inspectNotHandled($package);
             default:
                 return $this->inspectUnexpectedCommand($package, $this->responseCommand);

src/ClientOperations/AbstractSubscriptionOperation.php

@@ -149,7 +149,7 @@ public function inspectPackage(TcpPackage $package): InspectionResult
             }
 
             switch ($package->command()->value()) {
-                case TcpCommand::SubscriptionDropped:
+                case TcpCommand::SUBSCRIPTION_DROPPED:
                     $message = new SubscriptionDroppedMessage();
                     $message->parseFromString($package->data());
 
@@ -183,15 +183,15 @@ public function inspectPackage(TcpPackage $package): InspectionResult
                     }
 
                     return new InspectionResult(InspectionDecision::endOperation(), 'SubscriptionDropped: ' . $message->getReason());
-                case TcpCommand::NotAuthenticatedException:
+                case TcpCommand::NOT_AUTHENTICATED_EXCEPTION:
                     $this->dropSubscription(SubscriptionDropReason::notAuthenticated(), new NotAuthenticatedException());
 
                     return new InspectionResult(InspectionDecision::endOperation(), 'NotAuthenticated');
-                case TcpCommand::BadRequest:
+                case TcpCommand::BAD_REQUEST:
                     $this->dropSubscription(SubscriptionDropReason::serverError(), new ServerError());
 
                     return new InspectionResult(InspectionDecision::endOperation(), 'BadRequest');
-                case TcpCommand::NotHandled:
+                case TcpCommand::NOT_HANDLED:
                     if (null !== $this->subscription) {
                         throw new \Exception('NotHandledException command appeared while we were already subscribed');
                     }

src/ClientOperations/CreatePersistentSubscriptionOperation.php

@@ -75,7 +75,7 @@ protected function createRequestDto(): ProtobufMessage
         $message->setReadBatchSize($this->settings->readBatchSize());
         $message->setBufferSize($this->settings->bufferSize());
         $message->setMaxRetryCount($this->settings->maxRetryCount());
-        $message->setPreferRoundRobin($this->settings->namedConsumerStrategy()->name() === SystemConsumerStrategies::RoundRobin);
+        $message->setPreferRoundRobin($this->settings->namedConsumerStrategy()->name() === SystemConsumerStrategies::ROUND_ROBIN);
         $message->setCheckpointAfterTime($this->settings->checkPointAfterMilliseconds());
         $message->setCheckpointMaxCount($this->settings->maxCheckPointCount());
         $message->setCheckpointMinCount($this->settings->minCheckPointCount());

src/ClientOperations/UpdatePersistentSubscriptionOperation.php

@@ -75,7 +75,7 @@ protected function createRequestDto(): ProtobufMessage
         $message->setReadBatchSize($this->settings->readBatchSize());
         $message->setBufferSize($this->settings->bufferSize());
         $message->setMaxRetryCount($this->settings->maxRetryCount());
-        $message->setPreferRoundRobin($this->settings->namedConsumerStrategy()->name() === SystemConsumerStrategies::RoundRobin);
+        $message->setPreferRoundRobin($this->settings->namedConsumerStrategy()->name() === SystemConsumerStrategies::ROUND_ROBIN);
         $message->setCheckpointAfterTime($this->settings->checkPointAfterMilliseconds());
         $message->setCheckpointMaxCount($this->settings->maxCheckPointCount());
         $message->setCheckpointMinCount($this->settings->minCheckPointCount());

src/Common/SystemConsumerStrategies.php

@@ -15,10 +15,10 @@
 class SystemConsumerStrategies
 {
     // Distributes events to a single client until it is full. Then round robin to the next client.
-    public const DispatchToSingle = 'DispatchToSingle';
+    public const DISPATCH_TO_SINGLE = 'DispatchToSingle';
     // Distribute events to each client in a round robin fashion.
-    public const RoundRobin = 'RoundRobin';
+    public const ROUND_ROBIN = 'RoundRobin';
     // Distribute events of the same streamId to the same client until it disconnects on a best efforts basis.
     // Designed to be used with indexes such as the category projection.
-    public const Pinned = 'Pinned';
+    public const PINNED = 'Pinned';
 }

src/Common/SystemEventTypes.php

@@ -15,13 +15,13 @@
 class SystemEventTypes
 {
     // event type for stream deleted
-    public const StreamDeleted = '$streamDeleted';
+    public const STREAM_DELETED = '$streamDeleted';
     // event type for statistics
-    public const StatsCollection = '$statsCollected';
+    public const STATS_COLLECTED = '$statsCollected';
     // event type for linkTo
-    public const LinkTo = '$>';
+    public const LINK_TO = '$>';
     // event type for stream metadata
-    public const StreamMetadata = '$metadata';
+    public const STREAM_METADATA = '$metadata';
     // event type for the system settings
-    public const Settings = '$settings';
+    public const SETTINGS = '$settings';
 }

src/Common/SystemMetadata.php

@@ -16,29 +16,29 @@ class SystemMetadata
 {
     // The definition of the MaxAge value assigned to stream metadata
     // Setting this allows all events older than the limit to be deleted
-    public const MaxAge = '$maxAge';
+    public const MAX_AGE = '$maxAge';
     // The definition of the MaxCount value assigned to stream metadata
     // setting this allows all events with a sequence less than current -maxcount to be deleted
-    public const MaxCount = '$maxCount';
+    public const MAX_COUNT = '$maxCount';
     // The definition of the Truncate Before value assigned to stream metadata
     // setting this allows all events prior to the integer value to be deleted
-    public const TruncateBefore = '$tb';
+    public const TRUNCATE_BEFORE = '$tb';
     // Sets the cache control in seconds for the head of the stream.
-    public const CacheControl = '$cacheControl';
+    public const CACHE_CONTROL = '$cacheControl';
     // The acl definition in metadata
-    public const Acl = '$acl';
+    public const ACL = '$acl';
     // to read from a stream
-    public const AclRead = '$r';
+    public const ACL_READ = '$r';
     // to write to a stream
-    public const AclWrite = '$w';
+    public const ACL_WRITE = '$w';
     // to delete a stream
-    public const AclDelete = '$d';
+    public const ACL_DELETE = '$d';
     // to read metadata
-    public const AclMetaRead = '$mr';
+    public const ACL_META_READ = '$mr';
     // to write metadata
-    public const AclMetaWrite = '$mw';
+    public const ACL_META_WRITE = '$mw';
     // The user default acl stream
-    public const UserStreamAcl = '$userStreamAcl';
+    public const USER_STREAM_ACL = '$userStreamAcl';
     // the system stream defaults acl stream
-    public const SystemStreamAcl = '$systemStreamAcl';
+    public const SYSTEM_STREAM_ACL = '$systemStreamAcl';
 }

src/Common/SystemRoles.php

@@ -14,7 +14,7 @@
 
 class SystemRoles
 {
-    public const All = '$all';
-    public const Admins = '$admins';
-    public const Ops = '$ops';
+    public const ALL = '$all';
+    public const ADMINS = '$admins';
+    public const OPS = '$ops';
 }

src/Common/SystemStreams.php

@@ -14,12 +14,12 @@
 
 class SystemStreams
 {
-    public const PersistentSubscriptionConfig = '$persistentSubscriptionConfig';
-    public const AllStream = '$all';
-    public const StreamsStream = '$streams';
-    public const SettingsStream = '$settings';
-    public const StatsStreamPrefix = '$stats';
-    public const ScavengesStream = '$scavenges';
+    public const PERSISTENT_SUBSCRIPTION_CONFIG = '$persistentSubscriptionConfig';
+    public const ALL_STREAM = '$all';
+    public const STREAMS_STREAM = '$streams';
+    public const SETTINGS_STREAM = '$settings';
+    public const STATS_STREAM_PREFIX = '$stats';
+    public const SCAVANGE_STREAM = '$scavenges';
 
     public static function metastreamOf(string $streamId): string
     {

src/ConditionalWriteStatus.php

@@ -20,9 +20,9 @@ class ConditionalWriteStatus
         'StreamDeleted' => 2,
     ];
 
-    public const Succeeded = 0;
-    public const VersionMismatch = 1;
-    public const StreamDeleted = 2;
+    public const SUCCEEDED = 0;
+    public const VERSION_MISMATCH = 1;
+    public const STREAM_DELETED = 2;
 
     private $name;
     private $value;

src/ConnectionSettingsBuilder.php

@@ -33,21 +33,21 @@ class ConnectionSettingsBuilder
     /** @var bool */
     private $verboseLogging = false;
     /** @var int */
-    private $maxQueueSize = Consts::DefaultMaxQueueSize;
+    private $maxQueueSize = Consts::DEFAULT_MAX_QUEUE_SIZE;
     /** @var int */
-    private $maxConcurrentItems = Consts::DefaultMaxConcurrentItems;
+    private $maxConcurrentItems = Consts::DEFAULT_MAX_CONCURRENT_ITEMS;
     /** @var int */
-    private $maxRetries = Consts::DefaultMaxOperationRetries;
+    private $maxRetries = Consts::DEFAULT_MAX_OPERATIONS_RETRY;
     /** @var int */
-    private $maxReconnections = Consts::DefaultMaxReconnections;
+    private $maxReconnections = Consts::DEFAULT_MAX_RECONNECTIONS;
     /** @var bool */
-    private $requireMaster = Consts::DefaultRequireMaster;
+    private $requireMaster = Consts::DEFAULT_REQUIRE_MASTER;
     /** @var int */
-    private $reconnectionDelay = Consts::DefaultReconnectionDelay;
+    private $reconnectionDelay = Consts::DEFAULT_RECONNECTION_DELAY;
     /** @var int */
-    private $operationTimeout = Consts::DefaultOperationTimeout;
+    private $operationTimeout = Consts::DEFAULT_OPERATION_TIMEOUT;
     /** @var int */
-    private $operationTimeoutCheckPeriod = Consts::DefaultOperationTimeoutCheckPeriod;
+    private $operationTimeoutCheckPeriod = Consts::DEFAULT_OPERATION_TIMEOUT_CHECK_PERIOD;
     /** @var UserCredentials|null */
     private $defaultUserCredentials;
     /** @var bool */
@@ -67,9 +67,9 @@ class ConnectionSettingsBuilder
     /** @var string */
     private $clusterDns = '';
     /** @var int */
-    private $maxDiscoverAttempts = Consts::DefaultMaxClusterDiscoverAttempts;
+    private $maxDiscoverAttempts = Consts::DEFAULT_MAX_CLUSTER_DISCOVER_ATTEMPTS;
     /** @var int */
-    private $gossipExternalHttpPort = Consts::DefaultClusterManagerExternalHttpPort;
+    private $gossipExternalHttpPort = Consts::DEFAULT_CLUSTER_MANAGER_EXTERNAL_HTTP_PORT;
     /** @var int */
     private $gossipTimeout = 1000;
     /** @var GossipSeed[] */

src/EventNumber.php

@@ -14,6 +14,6 @@
 
 class EventNumber
 {
-    public const DeletedStream = \PHP_INT_MAX;
-    public const Invalid = -\PHP_INT_MAX - 1;
+    public const DELETED_STREAM = \PHP_INT_MAX;
+    public const INVALID = -\PHP_INT_MAX - 1;
 }

src/EventReadStatus.php

@@ -21,10 +21,10 @@ class EventReadStatus
         'StreamDeleted' => 3,
     ];
 
-    public const Success = 0;
-    public const NotFound = 1;
-    public const NoStream = 2;
-    public const StreamDeleted = 3;
+    public const SUCCESS = 0;
+    public const NOT_FOUND = 1;
+    public const NO_STREAM = 2;
+    public const STREAM_DELETED = 3;
 
     private $name;
     private $value;

src/EventStoreConnectionBuilder.php

@@ -16,7 +16,6 @@
 use Prooph\EventStoreClient\EventStoreSyncConnection as SyncConnection;
 use Prooph\EventStoreClient\Exception\InvalidArgumentException;
 use Prooph\EventStoreClient\Internal\ClusterDnsEndPointDiscoverer;
-use Prooph\EventStoreClient\Internal\Consts;
 use Prooph\EventStoreClient\Internal\EventStoreAsyncNodeConnection;
 use Prooph\EventStoreClient\Internal\EventStoreSyncNodeConnection;
 use Prooph\EventStoreClient\Internal\SingleEndpointDiscoverer;
@@ -35,6 +34,8 @@ class EventStoreConnectionBuilder
      */
     private const CHAR_UNRESERVED = 'a-zA-Z0-9_\-\.~\pL';
 
+    private const TCP_PORT_DEFAULT = 1113;
+
     /** @throws \Exception */
     public static function createAsyncFromBuilder(
         string $connectionString = null,
@@ -222,7 +223,7 @@ private static function parseUri(string $connectionString): array
 
         $scheme = isset($parts['scheme']) ? self::filterScheme($parts['scheme']) : '';
         $host = isset($parts['host']) ? \strtolower($parts['host']) : '';
-        $port = isset($parts['port']) ? (int) $parts['port'] : Consts::TcpPortDefault;
+        $port = isset($parts['port']) ? (int) $parts['port'] : self::TCP_PORT_DEFAULT;
         $user = isset($parts['user']) ? self::filterUserInfoPart($parts['user']) : '';
         $pass = $parts['pass'] ?? '';
 

src/ExpectedVersion.php

@@ -15,11 +15,11 @@
 class ExpectedVersion
 {
     // This write should not conflict with anything and should always succeed.
-    public const Any = -2;
+    public const ANY = -2;
     // The stream being written to should not yet exist. If it does exist treat that as a concurrency problem.
-    public const NoStream = -1;
+    public const NO_STREAM = -1;
     // The stream should exist and should be empty. If it does not exist or is not empty treat that as a concurrency problem.
-    public const EmptyStream = -1;
+    public const EMPTY_STREAM = -1;
     // The stream should exist. If it or a metadata stream does not exist treat that as a concurrency problem.
-    public const StreamExists = -4;
+    public const STREAM_EXISTS = -4;
 }