Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subscription dropped #126

Merged
merged 1 commit into from
May 3, 2020
Merged

Fix subscription dropped #126

merged 1 commit into from
May 3, 2020

Conversation

enumag
Copy link
Member

@enumag enumag commented Apr 26, 2020 •
edited
Loading

Just notice this potential bug while reading the code. I didn't actually encounter it.

StartSubscriptionMessage::subscriptionDropped() can return null in which case this would cause an error.

WIP because we should add a test for this.

@enumag enumag added the bug Something isn't working label Apr 26, 2020
@coveralls
Copy link

coveralls commented Apr 26, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 726

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 67.192%
Totals Coverage Status
Change from base Build 718: 0.01%
Covered Lines: 3195
Relevant Lines: 4755
💛 - Coveralls

@prolic
Copy link
Member

prolic commented Apr 26, 2020

good catch! thanks

@enumag enumag marked this pull request as draft May 2, 2020 20:07
@enumag enumag force-pushed the fix-subscription-dropped branch from 665e8ec to c174adc Compare May 3, 2020 09:05
@enumag enumag changed the title WIP: Fix subscription dropped Fix subscription dropped May 3, 2020
@enumag
Copy link
Member Author

enumag commented May 3, 2020

I tried but I have no idea how to write a test for this... Maybe it isn't necessary - psalm should report this bug as well I think.

@prolic prolic marked this pull request as ready for review May 3, 2020 23:32
@prolic prolic merged commit 6981e99 into master May 3, 2020
@prolic
Copy link
Member

prolic commented May 3, 2020

merged, thanks.

@prolic prolic deleted the fix-subscription-dropped branch May 3, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enumag @coveralls @prolic